Skip to content

Commit

Permalink
handle network disruption case
Browse files Browse the repository at this point in the history
  • Loading branch information
@noname0443
noname0443 committed Mar 5, 2025
1 parent faeb034 commit 9616c65
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
12 changes: 5 additions & 7 deletions internal/app/app.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,11 @@ func (app *App) updateActiveNodes(clusterState, clusterStateDcs map[string]*Node
if err != nil {
app.logger.Errorf("failed to enable semi-sync on slave %s: %v", host, err)
}
mysql_host := app.cluster.Get(host)
err = mysql_host.SetDefaultReplicationSettings(masterNode)
if err != nil {
app.logger.Errorf("failed to set default replication settings %s: %v", host, err)
}
}
if waitSlaveCount < oldWaitSlaveCount {
err := app.adjustSemiSyncOnMaster(masterNode, masterState, waitSlaveCount)
Expand Down Expand Up @@ -1362,9 +1367,6 @@ func (app *App) chooseReplicaToOptimize(

func (app *App) getMostDesirableReplicaToOptimize(positions []nodePosition) (string, error) {
lagThreshold := app.config.OptimizeReplicationLagThreshold
if app.config.ASync {
lagThreshold = app.config.OptimizeReplicationLagThresholdAsync
}
return getMostDesirableNode(app.logger, positions, lagThreshold)
}

Expand Down Expand Up @@ -1399,11 +1401,7 @@ func (app *App) isReplicationLagUnderThreshold(

lag := status.GetReplicationLag().Float64
lagThreshold := app.config.OptimizeReplicationLagThreshold.Seconds()
asyncLagThreshold := app.config.OptimizeReplicationLagThresholdAsync.Seconds()

if app.config.ASync && lag < asyncLagThreshold {
return true, nil
}
if !app.config.ASync && lag < lagThreshold {
return true, nil
}
Expand Down
2 changes: 0 additions & 2 deletions internal/config/config.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ type Config struct {
ForceSwitchover bool `config:"force_switchover" yaml:"force_switchover"`
OptimizeReplicationBeforeSwitchover bool `config:"optimize_replication_before_switchover" yaml:"optimize_replication_before_switchover"`
OptimizeReplicationLagThreshold time.Duration `config:"optimize_replication_lag_threshold" yaml:"optimize_replication_lag_threshold"`
OptimizeReplicationLagThresholdAsync time.Duration `config:"optimize_replication_lag_threshold_async" yaml:"optimize_replication_lag_threshold_async"`
OptimizeReplicationConvergenceTimeout time.Duration `config:"optimize_replication_convergence_timeout" yaml:"optimize_replication_convergence_timeout"`
}

Expand Down Expand Up @@ -202,7 +201,6 @@ func DefaultConfig() (Config, error) {
=======
>>>>>>> 04a56d6 (Delegate responsability of applying turbo mode to ISwitchHelper)

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / lint 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / all_unittests 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_discovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repl_mon.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / analyze 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_management.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=active_nodes.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=priority.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=failover.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_to.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=free_space.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async_setting.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=CLI.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_failure.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=recovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=async.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=maintenance.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=offline_mode.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=statefile.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=events_reenable.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=events_reenable.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repair.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_from.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=CLI.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_failure.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=offline_mode.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=external_replication.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=active_nodes.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_management.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repair.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=statefile.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=failover.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_discovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=maintenance.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=recovery.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_from.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=priority.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=free_space.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repl_mon.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }

Check failure on line 202 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_to.feature make test) 

syntax error: unexpected ) in composite literal; possibly missing comma or }
OptimizeReplicationLagThreshold: 60 * time.Second,
OptimizeReplicationLagThresholdAsync: 120 * time.Second,
OptimizeReplicationConvergenceTimeout: 300 * time.Second,

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / lint 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / all_unittests 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_discovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repl_mon.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / analyze 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_management.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=active_nodes.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=priority.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=failover.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_to.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=free_space.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async_setting.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=CLI.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_failure.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=recovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=async.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=maintenance.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=offline_mode.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=statefile.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=events_reenable.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=events_reenable.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repair.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_from.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=CLI.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_failure.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=offline_mode.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=external_replication.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=active_nodes.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_management.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repair.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=statefile.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=failover.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_discovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=maintenance.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=recovery.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_from.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=priority.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=free_space.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repl_mon.feature make test) 

syntax error: unexpected :, expected := or = or comma

Check failure on line 204 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_to.feature make test) 

syntax error: unexpected :, expected := or = or comma
}
return config, nil

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / lint 

missing ',' in composite literal (typecheck)

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / lint 

syntax error: non-declaration statement outside function body (typecheck)

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / all_unittests 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_discovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repl_mon.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / analyze 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=host_management.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=active_nodes.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=priority.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=failover.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_to.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=free_space.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async_setting.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=CLI.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_failure.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=recovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=async.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=maintenance.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=offline_mode.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=statefile.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=events_reenable.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=events_reenable.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=repair.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (GODOG_FEATURE=switchover_from.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=CLI.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_failure.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=offline_mode.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=external_replication.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=active_nodes.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=crash_recovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_management.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repair.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=manager_switchover.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=statefile.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=failover.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=cascade_replicas.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=async.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=host_discovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=maintenance.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=recovery.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=zk_maintenance.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=readonly_filesystem.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_from.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=priority.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=free_space.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=repl_mon.feature make test) 

syntax error: non-declaration statement outside function body

Check failure on line 206 in internal/config/config.go

View workflow job for this annotation

GitHub Actions / test (VERSION=8.0 GODOG_FEATURE=switchover_to.feature make test) 

syntax error: non-declaration statement outside function body
Expand Down
1 change: 0 additions & 1 deletion tests/images/mysql/mysync.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,4 @@ manager_switchover: ${MANAGER_SWITCHOVER:-true}
manager_election_delay_after_quorum_loss: ${MANAGER_ELECTION_DELAY_AFTER_QUORUM_LOSS:-15s}
manager_lock_acquire_delay_after_quorum_loss: ${MANAGER_LOCK_ACQUIRE_DELAY_AFTER_QUORUM_LOSS:-30s}
optimize_replication_lag_threshold: 60s
optimize_replication_lag_threshold_async: 120s
optimize_replication_convergence_timeout: 300s

0 comments on commit 9616c65

Please sign in to comment.