Fix replica return #108
Merged
Fix replica return #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teem0n
force-pushed
the
feature/fix_replica_return
branch
from
839a7e0 to
68ff6d9
Compare
teem0n
force-pushed
the
feature/fix_replica_return
branch
from
68ff6d9 to
208ff29
Compare
Fizic
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replica return fix
Describe what this PR fix
When replicas with semi-sync enabled returns to lone master, they could be ahead of master for some reasons.
In this case master may become stuck, as it waits for ACK of transaction, that is already present on replica.
Replication restart helps