restart only replicas ahead of the master #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teem0n
force-pushed
the
feature/restart_only_ahead_replicas
branch
from
22b08af to
09b1143
Compare
bularond
reviewed
Jun 26, 2024
teem0n
force-pushed
the
feature/restart_only_ahead_replicas
branch
from
05a4138 to
eb0f9e1
Compare
bularond
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restart only replicas ahead of the master
Describe what this PR fix
When replicas return to active nodes it may be streaming binlog. If binlog is big enough and we restart replication - we will interrupt download process. So we should restart only replicas ahead, as they have all required binary logs