Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External replication refactoring #39

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

noname0443
Copy link
Collaborator

@noname0443 noname0443 commented Sep 14, 2023

I want to make "strategy" pattern with IExternalReplication in app. To reach this purpose I made UnimplementedExternalReplication which contain empty methods and ExternalReplication which contain Node methods.

@noname0443 noname0443 changed the title External replication refactoring 2 External replication refactoring Sep 14, 2023
internal/app/replication/replication.go Outdated Show resolved Hide resolved
internal/app/app.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/mysql/queries.go Outdated Show resolved Hide resolved
internal/app/app.go Outdated Show resolved Hide resolved
@noname0443 noname0443 requested a review from Fizic September 15, 2023 09:41
internal/app/app.go Outdated Show resolved Hide resolved
internal/app/replication/mysql.go Outdated Show resolved Hide resolved
internal/app/replication/mysql.go Outdated Show resolved Hide resolved
internal/app/replication/mysql.go Outdated Show resolved Hide resolved
@noname0443 noname0443 marked this pull request as ready for review September 18, 2023 18:30
@noname0443 noname0443 requested a review from teem0n September 18, 2023 18:30
@noname0443 noname0443 force-pushed the external-replication-refactoring-2 branch from 6579345 to 05149a4 Compare September 19, 2023 17:53
internal/app/app.go Show resolved Hide resolved
@teem0n teem0n merged commit 5bb7474 into yandex:master Sep 25, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants