support async replication #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moridin26
changed the title
ostinru
reviewed
Mar 17, 2024
internal/config/config.go
Outdated
| @@ -88,6 +88,8 @@ type Config struct { | |||
| ReplicationChannel string `config:"replication_channel" yaml:"replication_channel"` | |||
| ExternalReplicationChannel string `config:"external_replication_channel" yaml:"external_replication_channel"` | |||
| ExternalReplicationType util.ExternalReplicationType `config:"external_replication_type" yaml:"external_replication_type"` | |||
| ASync bool `config:"a_sync" yaml:"a_sync"` | |||
| ASyncAllowedLag int64 `config:"a_sync_allowed_lag" yaml:"a_sync_allowed_lag"` | |||
There was a problem hiding this comment.
New setting which will allow client to set server in async mode. In async mode in case of failover mysync will promote slave to new master even if it has replication delay, but only if delay less then ASyncAllowedLag
ostinru
reviewed
Mar 19, 2024
internal/mysql/queries.go
Outdated
| @@ -123,4 +125,6 @@ var DefaultQueries = map[string]string{ | |||
| querySetInnodbFlushLogAtTrxCommit: `SET GLOBAL innodb_flush_log_at_trx_commit = :level`, | |||
| queryGetReplicationSettings: `SELECT @@innodb_flush_log_at_trx_commit as InnodbFlushLogAtTrxCommit, @@sync_binlog as SyncBinlog`, | |||
| querySetSyncBinlog: `SET GLOBAL sync_binlog = :sync_binlog`, | |||
| queryGetMdbReplMonTs: `SELECT UNIX_TIMESTAMP(ts) AS ts FROM mysql.mdb_repl_mon`, | |||
There was a problem hiding this comment.
This one looks very specific to your installation. Probably, we should use data from replication_applier_status_by_worker table OR move mdb_repl_mon to mysync.
added 6 commits
March 19, 2024 21:36
teem0n
reviewed
Apr 4, 2024
internal/app/app.go
Outdated
| @@ -700,6 +700,11 @@ func (app *App) stateManager() appState { | |||
| app.logger.Errorf("failed to update active nodes in dcs: %v", err) | |||
| } | |||
|
|
|||
| err = app.updateMdbReplMonTS(master) | |||
| if err != nil { | |||
| app.logger.Errorf("failed to update mdb_repl_mon timestamp: %v", err) | |||
There was a problem hiding this comment.
We should explicitly mention "in dcs"
internal/app/app.go
Outdated
| return false, nil | ||
| } | ||
| if app.config.ASync && switchover.Cause == CauseAuto { | ||
| app.logger.Infof("async mode is active and this is auto switch so we checking new master delay") |
There was a problem hiding this comment.
May be we should move this to async file?
teem0n
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.