Added config testing (odyssey --test) (#537)

* added configuration testing (odyssey --test)

* fixes

* fix names

* fix names

* apply fmt

* start create tests

* rebuild

* tests done

* --test no longer forks the process

* config without rules is no longer valid

* fix tests

* fix storage_type tests

* fix storage_tls tests

* fix config-examples/odyssey-aq.conf

* change .gitignore

* rm .DS_Store

.gitignore

@@ -28,3 +28,4 @@ docker/bin/odyssey-asan
 odyssey.conf.example
 odyssey.init
 odyssey.logrotate
+.DS_Store

config-examples/odyssey-aq.conf

@@ -158,4 +158,4 @@ locks_dir "/tmp/odyssey"
 
 graceful_die_on_errors yes
 enable_online_restart no
-bindwith_reuseport yes
+bindwith_reuseport yes

docker/Dockerfile

@@ -2,16 +2,20 @@ FROM golang:latest as base
 
 RUN mkdir -p /ody-integration-test
 RUN mkdir -p /prep_stmts
+RUN mkdir -p /config-validation
 COPY ./docker/ody-integration-test /ody-integration-test
 COPY ./docker/prep_stmts /prep_stmts
+COPY ./docker/config-validation /config-validation
 
 WORKDIR /ody-integration-test
-
 RUN go mod download && cd pkg && go build -o ody-integration-test
 
 WORKDIR /prep_stmts
 RUN go mod download && cd pkg && go build -o pstmts-test
 
+WORKDIR /config-validation
+RUN go mod download && cd pkg && go build -o config-validation
+
 FROM ubuntu:focal
 
 ENV DEBIAN_FRONTEND=noninteractive
@@ -58,9 +62,11 @@ RUN mkdir /tmp/odyssey
 COPY ./docker/odyssey.conf /etc/odyssey/odyssey.conf
 COPY ./docker/lagpolling/lag-conf.conf /etc/odyssey/lag-conf.conf
 COPY ./docker/prep_stmts/pstmts.conf /etc/odyssey/pstmts.conf
+COPY ./docker/config-validation/configs /etc/odyssey/configs
 
 COPY --from=base /ody-integration-test/pkg/ody-integration-test /ody-integration-test
 COPY --from=base /prep_stmts/pkg/pstmts-test /pstmts-test
+COPY --from=base /config-validation/pkg/config-validation /config-validation
 COPY ./docker/scram /scram
 COPY ./docker/hba /hba
 COPY ./docker/auth_query /auth_query

docker/config-validation/configs/auth_query/invalid/odyssey-test1.conf

@@ -0,0 +1,22 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "none"
+                auth_query "auth_query"
+                auth_query_db "db"
+        }
+}

docker/config-validation/configs/auth_query/invalid/odyssey-test2.conf

@@ -0,0 +1,22 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "none"
+                auth_query "auth_query"
+                auth_query_user "user"
+        }
+}

docker/config-validation/configs/auth_query/invalid/odyssey-test3.conf

@@ -0,0 +1,21 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "none"
+                auth_query "auth_query"
+        }
+}

docker/config-validation/configs/auth_query/valid/odyssey-test1.conf

@@ -0,0 +1,23 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "none"
+                auth_query "auth_query"
+                auth_query_user "user"
+                auth_query_db "db"
+        }
+}

docker/config-validation/configs/authentication/invalid/odyssey-test1.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "md5"
+        }
+}

docker/config-validation/configs/authentication/invalid/odyssey-test2.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "scram-sha-256"
+        }
+}

docker/config-validation/configs/authentication/invalid/odyssey-test3.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "kek"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test1.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "none"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test10.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "cert"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test2.conf

@@ -0,0 +1,20 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "block"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test3.conf

@@ -0,0 +1,21 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "clear_text"
+                password "password"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test4.conf

@@ -0,0 +1,21 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "md5"
+                password "password"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test5.conf

@@ -0,0 +1,23 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "md5"
+                auth_query "auth_query"
+                auth_query_user "user"
+                auth_query_db "db"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test6.conf

@@ -0,0 +1,23 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "scram-sha-256"
+                auth_query "auth_query"
+                auth_query_user "user"
+                auth_query_db "db"
+        }
+}

docker/config-validation/configs/authentication/valid/odyssey-test7.conf

@@ -0,0 +1,21 @@
+unix_socket_dir "/tmp"
+unix_socket_mode "0644"
+
+log_format "%p %t %l [%i %s] (%c) %m\n"
+
+listen {
+        host "*"
+}
+
+storage "postgres_server" {
+        type "remote"
+}
+
+database "db" {
+        user "user" {
+                storage "postgres_server"
+                pool "session"
+                authentication "scram-sha-256"
+                password "password"
+        }
+}