option for strict sequential route matching #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshke
reviewed
Apr 5, 2024
| @@ -346,6 +347,63 @@ od_rule_t *od_rules_forward(od_rules_t *rules, char *db_name, char *user_name, | |||
| return rule_default_default_default; | |||
| } | |||
|
|
|||
| static od_rule_t * | |||
| od_rules_forward_sequential(od_rules_t *rules, char *db_name, char *user_name, | |||
There was a problem hiding this comment.
maybe we can rewrite od_rules_forward logic to handle sequential inside of it (consider macros if different signature needed)? Im not a big fan of rewriting core logic functions twice
There was a problem hiding this comment.
maybe we can rewrite
od_rules_forwardlogic to handlesequentialinside of it (consider macros if different signature needed)? Im not a big fan of rewriting core logic functions twice
But od_rules_forward_sequential significantly differs from old od_rules_forward, I think two separate functions are more clear
AndrewOvvv
reviewed
Apr 5, 2024
reshke
reviewed
Apr 5, 2024
reshke
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.