Keepalive usr default value #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 15, 2024 10:07
The value of tcp user timeout should be computed from keepalive values. This patch adds advice function to machinarium for formulae of keepalive + interval + probes - 0.5 Signed-off-by: rkhapov <[email protected]>
Now, default value of keepalive_usr_timeout will lead to adviced value of tcp usr timeout, computed with values of keepalive. Signed-off-by: rkhapov <[email protected]>
According to `man 7 tcp`, delay and interval values are presented seconds. But tcp user timeout are presented in milliseconds. So formula fixed. Signed-off-by: rkhapov <[email protected]>
reshke
approved these changes
Oct 15, 2024
rkhapov
added a commit
that referenced
this pull request
Nov 15, 2024
* machinarium: add advice tcp usr timeout fn The value of tcp user timeout should be computed from keepalive values. This patch adds advice function to machinarium for formulae of keepalive + interval + probes - 0.5 Signed-off-by: rkhapov <[email protected]> * sources/config_reader.c: use advice tcp usr timeout Now, default value of keepalive_usr_timeout will lead to adviced value of tcp usr timeout, computed with values of keepalive. Signed-off-by: rkhapov <[email protected]> * test_advice_keepalive_usr_timeout.c: fix milliseconds According to `man 7 tcp`, delay and interval values are presented seconds. But tcp user timeout are presented in milliseconds. So formula fixed. Signed-off-by: rkhapov <[email protected]> --------- Signed-off-by: rkhapov <[email protected]> Co-authored-by: rkhapov <[email protected]> (cherry picked from commit 2875a71) Signed-off-by: rkhapov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.