client max routing in workers #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new command will help to run format on different envs because of running formatting inside docker. Previous make fmt will stay, but is not very suitable. Signed-off-by: rkhapov <[email protected]>
Current od_worker function is quite heavy: it performs all message type processing in single switch construction. This patchs makes two new functions for every message types. Signed-off-by: rkhapov <[email protected]>
When checking the `client_max_routing` option in od_system(), it creates some problems with monitoring tools such as pgconsul (which assumes that Odyssey is not accepting new connections and needs to be restarted), and it is a poor design choice overall, aimed at solving the problem of CPU consumption by TLS handshakes. To solve this issue, tls threads needs to be created. They will only do the tls handshakes, it will allows to unload workers threads, which will be just ready to send the bytes between clients and servers, and even accept new connections. This patch performs one of the first steps to introduce tls threads: it moves the logic of 'client max routing' into worker from od_system(). Signed-off-by: rkhapov <[email protected]>
rkhapov
force-pushed
the
client-max-routing-in-workers
branch
2 times, most recently
from
1655bc2 to
d088bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.