Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msg leaks somewhere #742

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Msg leaks somewhere #742

merged 4 commits into from
Dec 16, 2024

Conversation

rkhapov
Copy link
Collaborator

@rkhapov rkhapov commented Dec 16, 2024 •
edited
Loading

  • add machine_wait_list_t - 'condition variable' without channels
  • fix router->wait_bus leak
  • add channel size functions
  • atomics inside machinarium

rkhapov added 3 commits December 16, 2024 11:40
machinarium/channels: add get_size funcs
ca8d44c 
Can be used in some debuggin workarounds

Signed-off-by: rkhapov <[email protected]>
machinarium/wait_list*
212e563 
This patch adds mm_wait_list_t type
which will be used as condition variable everywhere it needed.

Ex.: wait_bus in router creates it's own wait_list, but with channels
and therefore it has memory leaks because of inconsistency of it usages.

Signed-off-by: rkhapov <[email protected]>
sources/route.h: fix wait_bus inconsistency
2488440 
route->wait_bus was implemented with channels.
This leads to memory leaks because of inconsystency of queued
clients notifications.

This patch replaces channel with wait_list, which will not lead
to memory leaks.

Signed-off-by: rkhapov <[email protected]>
@rkhapov rkhapov marked this pull request as draft December 16, 2024 11:49
sources/config_reader.c: fix small memleak
b15b799 
just to silence asan

Signed-off-by: rkhapov <[email protected]>
@rkhapov rkhapov marked this pull request as ready for review December 16, 2024 12:20
@rkhapov rkhapov merged commit 806856e into yandex:master Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4m x4m x4m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkhapov @x4m