MDB-33721: extracted wal_reciever info, fix finish_iteration position and cascade replication #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedusia
previously approved these changes
Feb 5, 2025
fedusia
previously approved these changes
Feb 6, 2025
vicpopov
requested changes
Feb 17, 2025
added 3 commits
February 24, 2025 15:35
…, added brief development info,, fix func name for python above 3.2
vicpopov
requested changes
Feb 28, 2025
aak74
changed the title
vicpopov
requested changes
Mar 7, 2025
| @@ -88,7 +91,7 @@ def update_replication_type(self, db_state, ha_replics): | |||
| # https://www.postgresql.org/message-id/15617-8dfbde784d8e3258%40postgresql.org | |||
| self._db.check_walsender(db_state['replics_info'], holder_fqdn) | |||
| else: | |||
| logging.info("Here we should turn synchronous replication on.") | |||
| logging.info("ACTION. Here we should turn synchronous replication on.") | |||
There was a problem hiding this comment.
ACTION. Turning synchronous replication ON.
| @@ -1050,7 +1034,7 @@ def _simple_primary_switch(self, limit, new_primary, is_dead): | |||
| primary_switch_checks = self.config.getint('replica', 'primary_switch_checks') | |||
| need_restart = self.config.getboolean('replica', 'primary_switch_restart') | |||
|
|
|||
| logging.info('Starting simple primary switch.') | |||
| logging.info('ACTION. Starting simple primary switch to {}'.format(new_primary)) | |||
There was a problem hiding this comment.
Here we are just beginning a sequence of steps to perform switch, it is not a simple action that should be logged as intent with ACTION.
| @@ -1084,7 +1068,8 @@ def _simple_primary_switch(self, limit, new_primary, is_dead): | |||
| # | |||
| # The easy way succeeded. | |||
| # | |||
| logging.info('Simple primary switch succeeded.') | |||
| logging.info('ACTION. Simple switch primary to {} succeeded'.format(new_primary)) | |||
There was a problem hiding this comment.
Same as on R1037, it is not an ACTION, but a branch of execution that ended here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairing pgconsul crash and fix delay when exception occurs