-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring tests #123
Merged
grzanka
merged 23 commits into
master
from
95-add-comment-in-the-geodat-mentioning-name-of-the-figure
May 14, 2023
Merged
Refactoring tests #123
grzanka
merged 23 commits into
master
from
95-add-comment-in-the-geodat-mentioning-name-of-the-figure
May 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved issues in the following files with DeepSource Autofix: 1. tests/shieldhit/test_shieldhit_converter.py 2. tests/shieldhit/test_zones.py 3. tests/topas/conftest.py 4. tests/topas/test_topas_converter.py
Resolved issues in converter/topas/parser.py with DeepSource Autofix
hendzeld
reviewed
May 14, 2023
Co-authored-by: Dominik Hendzel <[email protected]>
Bogdan2423
reviewed
May 14, 2023
Bogdan2423
reviewed
May 14, 2023
Bogdan2423
reviewed
May 14, 2023
Bogdan2423
reviewed
May 14, 2023
Co-authored-by: Mateusz Wronka <[email protected]>
Co-authored-by: Mateusz Wronka <[email protected]>
Bogdan2423
approved these changes
May 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hendzeld
approved these changes
May 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
grzanka
deleted the
95-add-comment-in-the-geodat-mentioning-name-of-the-figure
branch
May 14, 2023 21:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on #95 I've figured out that the test suite can be improved.
The score of this PR does a refactor of the tests directory.
The tests are grouped according to the simulator.