Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #123

Merged

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented May 12, 2023

During work on #95 I've figured out that the test suite can be improved.
The score of this PR does a refactor of the tests directory.
The tests are grouped according to the simulator.

Screenshot 2023-05-13 at 22 26 27

@grzanka grzanka linked an issue May 12, 2023 that may be closed by this pull request
@grzanka grzanka marked this pull request as draft May 12, 2023 15:23
@grzanka grzanka self-assigned this May 12, 2023
@grzanka grzanka changed the title Comments in generated files Refactoring tests May 13, 2023
deepsource-autofix bot and others added 5 commits May 13, 2023 20:08
Resolved issues in the following files with DeepSource Autofix:
1. tests/shieldhit/test_shieldhit_converter.py
2. tests/shieldhit/test_zones.py
3. tests/topas/conftest.py
4. tests/topas/test_topas_converter.py
@grzanka grzanka marked this pull request as ready for review May 13, 2023 20:25
deepsource-autofix bot and others added 2 commits May 13, 2023 20:25
Resolved issues in converter/topas/parser.py with DeepSource Autofix
@grzanka grzanka enabled auto-merge (squash) May 13, 2023 20:27
@grzanka grzanka requested review from hendzeld, Bogdan2423 and lequ0n May 13, 2023 20:27
@grzanka grzanka disabled auto-merge May 13, 2023 20:28
tests/topas/test_topas_converter.py Outdated Show resolved Hide resolved
tests/fluka/test_fluka_converter.py Outdated Show resolved Hide resolved
tests/fluka/test_fluka_converter.py Show resolved Hide resolved
tests/shieldhit/test_shieldhit_converter.py Show resolved Hide resolved
@grzanka grzanka requested a review from hendzeld May 14, 2023 10:55
grzanka and others added 2 commits May 14, 2023 14:45
@grzanka grzanka requested a review from Bogdan2423 May 14, 2023 12:47
Copy link
Contributor

@Bogdan2423 Bogdan2423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@hendzeld hendzeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grzanka grzanka merged commit 7a12210 into master May 14, 2023
@grzanka grzanka deleted the 95-add-comment-in-the-geodat-mentioning-name-of-the-figure branch May 14, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants