-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concept of new scoring output configuration #1932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@grzanka. Here's initial idea of how such dictionary will look like |
grzanka
reviewed
Jan 4, 2025
grzanka
reviewed
Jan 5, 2025
grzanka
reviewed
Jan 7, 2025
grzanka
approved these changes
Jan 7, 2025
@jagodek you can (squash)merge at will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake scoring output types.
This pull request includes several updates to the
ThreeEditor
module, focusing on improving the handling of scoring quantities and differential modifiers. The changes primarily involve updating method calls to include the current simulator context and refactoring code to use enums and utility functions for better maintainability.Updates to Scoring Quantity Handling:
src/ThreeEditor/Simulation/Scoring/ScoringQuantity.ts
: Updated methods to includecurrentSimulator
context forcanChangeMaterialMedium
andcanChangeNKMedium
checks. [1] [2] [3]Refactoring and Code Simplification:
src/ThreeEditor/Simulation/Scoring/ScoringQtyModifiers.ts
: Changed default parameter fordiffType
inDifferentialModifier
constructor to useDETECTOR_MODIFIERS.ANGLE
.src/ThreeEditor/Simulation/Scoring/ScoringQuantity.ts
: Updated constructor to use enumScoring.DETECTOR_KEYWORD.Dose
instead of string 'Dose'.Sidebar Properties Enhancements:
src/ThreeEditor/components/Sidebar/properties/category/QuantityConfiguration.tsx
: Refactored to usegetQuantityTypeOptions
and includedcurrentSimulator
context in method calls. [1] [2] [3] [4]src/ThreeEditor/components/Sidebar/properties/category/QuantityDifferentialScoring.tsx
: Updated to usegetQuantityModifiersOptions
and includedcurrentSimulator
context. [1] [2] [3]Miscellaneous Updates:
src/ThreeEditor/components/Sidebar/properties/fields/PropertyField.tsx
: ReplacedDETECTOR_MODIFIERS_OPTIONS
withDETECTOR_MODIFIERS_OPTIONS_TYPE
. [1] [2]src/ThreeEditor/js/sidebar/object/Object.Differentials.ts
: Updated to useDETECTOR_MODIFIERS_OPTIONS_TYPE
.src/ThreeEditor/js/sidebar/object/Object.Quantity.ts
: Changed to useSHIELDHIT_DETECTOR_KEYWORD_OPTIONS
and commented out unused code. [1] [2] [3]