-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
**What's the problem this PR addresses?** One of our tests on the `@types` auto-add was testing `@iarna/toml`, but this package actually contains types (but was reported as not having them due to a bug on Algolia's side). **How did you fix it?** I changed the package to `@babel/parser`, which doesn't have builtin types. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
- Loading branch information
Showing
12 changed files
with
35 additions
and
11 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/acceptance-tests/pkg-tests-fixtures/packages/@babel__parser-1.0.0/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "@babel/parser", | ||
"version": "7.23.0" | ||
} |
File renamed without changes.
4 changes: 4 additions & 0 deletions
4
packages/acceptance-tests/pkg-tests-fixtures/packages/@babel__traverse-7.99.0/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "@babel/traverse", | ||
"version": "7.99.0" | ||
} |
4 changes: 0 additions & 4 deletions
4
packages/acceptance-tests/pkg-tests-fixtures/packages/@iarna__toml-1.0.0/package.json
This file was deleted.
Oops, something went wrong.
File renamed without changes.
4 changes: 4 additions & 0 deletions
4
...s/acceptance-tests/pkg-tests-fixtures/packages/@types__babel_traverse-7.99.0/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "@types/babel__traverse", | ||
"version": "7.99.0" | ||
} |
4 changes: 0 additions & 4 deletions
4
packages/acceptance-tests/pkg-tests-fixtures/packages/@types__iarna__toml-1.0.0/package.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,14 +82,14 @@ describe(`Plugins`, () => { | |
makeTemporaryEnv({}, { | ||
tsEnableAutoTypes: true, | ||
}, async ({path, run, source}) => { | ||
await run(`add`, `@iarna/toml`); | ||
await run(`add`, `@babel/[email protected]`); | ||
|
||
await expect(readManifest(path)).resolves.toMatchObject({ | ||
dependencies: { | ||
[`@iarna/toml`]: `^1.0.0`, | ||
[`@babel/traverse`]: `7.99.0`, | ||
}, | ||
devDependencies: { | ||
[`@types/iarna__toml`]: `^1`, | ||
[`@types/babel__traverse`]: `^7`, | ||
}, | ||
}); | ||
}), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters