perf(run): improve yarn run performance #2577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Helps a bit with #2575.
Testing it on https://github.com/jest-community/eslint-plugin-jest (CC @SimenB), it seems to save ~345.7 ms.
This PR doesn't change anything linker-specific, so it should also slightly optimize
yarn run
with the PnP linker.Because #2576 overlaps with this PR in some places, the combined perf improvements of the 2 PRs will probably only save something like ~350-400ms.
How did you fix it?
makePathWrapper
s.ZipOpenFS
) if the package is a workspace.packageAccessibleBinaries
insideexecutePackageAccessibleBinaries
again, as they are already computed inside theexecute
method of theyarn run
command.getPackageAccessibleBinaries
- the remaining part still has to be sequential to guarantee consistent overwrite order of the binaries.Checklist