Infer which files should SDKs include using manifest data #5703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Some SDKs do not include all exposed files, making some features inaccessible to some editor integration. In particular, the ESLint SDK does not include
lib/unsupported-api.js
needed for its experimental flat config feature.Closes #5231
Closes #5471
How did you fix it?
As outlined in #5231, the list of exposed files can be inferred by reading the
main
,bin
, andexports
fields of the manifest. This PR switches all existing SDK generators to doing so. Some SDKs (e.g. Typescript) still requires some special treatment so the PR keeps some escape hatches.Questions
@yarnpkg/sdks
for a minor release for now.typescript-language-server
has not exposed a CJS entrypoint since 1.0.0, and as far as I know the SDK mechanism cannot support ESM files since loaders cannot be dynamically added once userland code starts execution. Should we just remove that SDK?import
condition?.mjs
files?Checklist