Fixes couple of release blockers #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
added a commit
that referenced
this pull request
Sep 15, 2023
**What's the problem this PR addresses?** The cache fix merged in #5730 had a bug that caused the global cache to be skipped when a package had no checksum - which happens when there are no lockfile in the project. This was detected by the perf regression visible on the dashboard: <img width="1381" alt="image" src="https://github.com/yarnpkg/berry/assets/1037931/11aed9d5-7946-418d-806a-6df78aee4734"> **How did you fix it?** I fixed the condition (it was "use the cache if there's a checksum and it's compatible", it should have been "use the cache if there's no checksum, or it's a compatible one") and added tests to avoid further regressions. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
CRA broke when we started required that
--cwdbe put before any other argument. CRA is mostly deprecated / unmaintained by now, but it has a decent amount of downloads (more thancreate-next-app), so it doesn't cost us much to special-case a fix for the v4 that we can then drop in v5.When a machine had a hot cache for package X in both cache versions A and B (each variant having its own checksum), when migrating a project cache version from A to B, Yarn would mistakenly try to validate the variant B using the checksum from variant A.
How did you fix it?
The
--cwdflag is now allowed (as a special case) at the end ofyarn add.I refactored the "is this locator compatible with the current cache key" function outside of
getLocatorPath.Checklist