-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various minor tweaks for website #5863
Conversation
Thanks for looking into all that 🙏
Yes! I wanted to rework the release workflow so I didn't immediately port the page, but didn't find the time and forgot to add it back. It's fine to replace publishing by the old page.
Ideally we shouldn't have commands that fail to parse - are they legit bugs?
I tend to prefer having one single source of truth (outside of when we completely replace the old documentation, like v1 -> v2 or v3 -> v4), to avoid people reading the wrong one and to make it easier to fix our own mistakes. That being said, having "this feature got added in X.Y" markers would be useful. Perhaps that'd be something for Clipanion?
Typedoc was a little complex and I didn't have time to port it / restyle it, so I put it aside. It can be added back, but perhaps there's a simpler API documentation generator we could use? Or even a Docusaurus plugin? |
In that case I will proceed with the original title and URL
Most of them are in blog posts or exposition where a placeholder arg (e.g. |
2e73d64
to
b62c1b7
Compare
Once we resolve the 2 outstanding questions I will mark this as ready. The TBDs will take some more time to investigate so let's not get blocked on them. |
969408f
to
1589d14
Compare
I have an idea for a better solution, but it is more involved and this PR is intended to be an aggregation of "low-hanging fruits" so as not to flood the PR queue. I'll make a separate PR.
I think having just
I think adding notes manually when we update docs for new features is suffice for now. If and when Clipanion get this feature we can integrate it.
That leaves
For now, I'll leave those alone. I'll rebase and mark this PR as ready. If maintainers think we should update them I can do it. /ping @arcanis |
Thanks a lot! |
What's the problem this PR addresses?
There are a number of build tooling and minor problems with the website. (Listed below)
How did you fix it?
Maintainers: I have marked this as draft for now due to the Questions/TODOs/TBDs. Most of these I just implemented the fix that I think is the most straightforward/reasonable. Feel free to edit/merge/cherry-pick anything here as you see fit.
The bundled TS type check is bugged (e.g. xterm-headless is reported as "no types")Fix: prioritize type entrypoints (types
andtypings
fields inpacakge.json
,types
condition) instead of normal (JS) entrypoints when resolving the package.cross-spawn
, which@yarnpkg/core
already depends onbuild
Question: What is the "Publishing" page? Is it supposed to be a re-written Release Workflow page?Question: This a not a very elegant solution. Are there better alternatives?webpack
warnsjs-yaml
on usingbuffer
buffer
polyfill as suggestedautoprefixer
warnssrc/css/custom.css
on usingtext-decoration-skip
CSS propertytext-decoration-skip-ink
instead as suggestedQuestion: Should we use versioned docs for v4+?TBD: While generating the CLI docs, run the CLI in JS instead of via the OS shell to avoid spawning a terminal windowTBD: The API reference is completely removed. What should we do about it?TBD: Should we updatecaniuse-lite
as suggested? Should we do it regularly?Closes #5667 (supersedes)
Closes #5860 (supersedes)
Closes #5894 (supersedes)Fixes #5707
Fixes #5805
Fixes #5832
Fixes #5861Fixes #5869Fixes #5926
Checklist