Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if stream_type in ("audio", "subtitle"): | ||
| pass | ||
| else: | ||
| if stream_type not in ("audio", "subtitle"): |
There was a problem hiding this comment.
Function download_file refactored with the following changes:
- Swap if/else to remove empty if body (
remove-pass-body)
Comment on lines
-136
to
+134
| if stream_type in ("audio", "subtitle"): | ||
| pass | ||
| else: | ||
| if stream_type not in ("audio", "subtitle"): |
There was a problem hiding this comment.
Function download_url_link refactored with the following changes:
- Swap if/else to remove empty if body (
remove-pass-body)
Comment on lines
-21
to
+31
| seconds, milliseconds = divmod(int(milliseconds), 1000) | ||
| seconds, milliseconds = divmod(milliseconds, 1000) | ||
| minutes, seconds = divmod(seconds, 60) | ||
| hours, minutes = divmod(minutes, 60) | ||
| days, hours = divmod(hours, 24) | ||
| tmp = (((str(days) + "d, ") if days else "") + | ||
| ((str(hours) + "h, ") if hours else "") + | ||
| ((str(minutes) + "m, ") if minutes else "") + | ||
| ((str(seconds) + "s, ") if seconds else "") + | ||
| ((str(milliseconds) + "ms, ") if milliseconds else "")) | ||
| tmp = ( | ||
| (f"{str(days)}d, " if days else "") | ||
| + (f"{str(hours)}h, " if hours else "") | ||
| + (f"{str(minutes)}m, " if minutes else "") | ||
| + (f"{str(seconds)}s, " if seconds else "") | ||
| + (f"{str(milliseconds)}ms, " if milliseconds else "") | ||
| ) |
There was a problem hiding this comment.
Function time_formatter refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast) - Use f-string instead of string concatenation [×5] (
use-fstring-for-concatenation)
Comment on lines
-79
to
+81
| if total_length < downloaded: | ||
| total_length = downloaded | ||
| total_length = max(total_length, downloaded) |
There was a problem hiding this comment.
Function download_coroutine refactored with the following changes:
- Replace comparison with min/max call (
min-max-identity) - Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
| return str(round(size, 2)) + " " + Dic_powerN[n] + 'B' | ||
| return f"{str(round(size, 2))} {Dic_powerN[n]}B" |
There was a problem hiding this comment.
Function humanbytes refactored with the following changes:
- Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation)
Comment on lines
-46
to
+56
| seconds, milliseconds = divmod(int(milliseconds), 1000) | ||
| seconds, milliseconds = divmod(milliseconds, 1000) | ||
| minutes, seconds = divmod(seconds, 60) | ||
| hours, minutes = divmod(minutes, 60) | ||
| days, hours = divmod(hours, 24) | ||
| tmp = ((str(days) + "d, ") if days else "") + \ | ||
| ((str(hours) + "h, ") if hours else "") + \ | ||
| ((str(minutes) + "m, ") if minutes else "") + \ | ||
| ((str(seconds) + "s, ") if seconds else "") + \ | ||
| ((str(milliseconds) + "ms, ") if milliseconds else "") | ||
| tmp = ( | ||
| (f"{str(days)}d, " if days else "") | ||
| + (f"{str(hours)}h, " if hours else "") | ||
| + (f"{str(minutes)}m, " if minutes else "") | ||
| + (f"{str(seconds)}s, " if seconds else "") | ||
| + (f"{str(milliseconds)}ms, " if milliseconds else "") | ||
| ) |
There was a problem hiding this comment.
Function TimeFormatter refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast) - Use f-string instead of string concatenation [×5] (
use-fstring-for-concatenation)
Comment on lines
-25
to
+30
| title = None | ||
| artist = None | ||
| thumb = None | ||
| duration = 0 | ||
|
|
||
| metadata = extractMetadata(createParser(file_loc)) | ||
| if metadata and metadata.has("title"): | ||
| title = metadata.get("title") | ||
| title = metadata.get("title") if metadata and metadata.has("title") else None |
There was a problem hiding this comment.
Function upload_audio refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Replace if statement with if expression [×2] (
assign-if-exp) - Replace multiple comparisons of same variable with
inoperator (merge-comparisons) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Move setting of default value for variable into
elsebranch (introduce-default-else)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!