Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zones reader (bsc#1216534) #1294

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix zones reader (bsc#1216534) #1294

merged 2 commits into from
Oct 25, 2023

Conversation

teclator
Copy link
Contributor

Problem

A recent change in firewall-cmd --list-all-zones output is breaking the zones reader as the default zone is not read properly and therefore it is considered to be deleted.

Solution

Adapted the firewalld zones reader ignoring anything after the zone name.

Testing

  • Adapted current unit test
  • Tested manually

@coveralls
Copy link

coveralls commented Oct 25, 2023

Coverage Status

coverage: 41.924% (+0.03%) from 41.893% when pulling 50ba1cc on fix_zones_reader into d1ae321 on SLE-15-SP6.

Adapted the zones reader to the new --list-all-zones output introduced
by firewalld 2.0.1 version (bsc#1216534)
@teclator teclator changed the base branch from master to SLE-15-SP6 October 25, 2023 12:22
Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shundhammer shundhammer merged commit 261c33b into SLE-15-SP6 Oct 25, 2023
@shundhammer shundhammer deleted the fix_zones_reader branch October 25, 2023 13:02
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #6 successfully finished
✔️ Created IBS submit request #311556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants