issue-2710: logging operations with SessionByOwner mapping (#2711)

ydb-platform · Dec 17, 2024 · e088770 · e088770
1 parent 68aa32b
commit e088770
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 7 deletions.
diff --git a/cloud/filestore/libs/storage/tablet/tablet_actor.cpp b/cloud/filestore/libs/storage/tablet/tablet_actor.cpp
@@ -591,10 +591,10 @@ void TIndexTabletActor::HandlePoisonPill(
     const TEvents::TEvPoisonPill::TPtr& ev,
     const TActorContext& ctx)
 {
-    Y_UNUSED(ev);
-
-    LOG_INFO_S(ctx, TFileStoreComponents::TABLET,
-        LogTag << " Stop tablet because of PoisonPill request");
+    LOG_INFO(ctx, TFileStoreComponents::TABLET,
+        "%s Stop tablet because of PoisonPill request, ev->Sender: %s",
+        LogTag.c_str(),
+        ev->Sender.ToString().c_str());
 
     Suicide(ctx);
 }
@@ -612,6 +612,11 @@ void TIndexTabletActor::HandleSessionDisconnected(
     const TEvTabletPipe::TEvServerDisconnected::TPtr& ev,
     const TActorContext& ctx)
 {
+    LOG_INFO(ctx, TFileStoreComponents::TABLET,
+        "%s Server disconnected, ev->Sender: %s",
+        LogTag.c_str(),
+        ev->Sender.ToString().c_str());
+
     OrphanSession(ev->Sender, ctx.Now());
 }
 

diff --git a/cloud/filestore/libs/storage/tablet/tablet_state_sessions.cpp b/cloud/filestore/libs/storage/tablet/tablet_state_sessions.cpp
@@ -190,6 +190,13 @@ TSession* TIndexTabletState::CreateSession(
     Impl->SessionByOwner.emplace(owner, session.get());
     Impl->SessionByClient.emplace(session->GetClientId(), session.get());
 
+    LOG_INFO(*TlsActivationContext, TFileStoreComponents::TABLET,
+        "%s created session c: %s, s: %s, owner: %s",
+        LogTag.c_str(),
+        session->GetClientId().c_str(),
+        session->GetSessionId().c_str(),
+        owner.ToString().c_str());
+
     return session.release();
 }
 
@@ -203,6 +210,13 @@ NActors::TActorId TIndexTabletState::RecoverSession(
         session->UpdateSubSession(sessionSeqNo, readOnly, owner);
     if (oldOwner) {
         Impl->SessionByOwner.erase(oldOwner);
+
+        LOG_INFO(*TlsActivationContext, TFileStoreComponents::TABLET,
+            "%s removed old owner for session c: %s, s: %s, owner: %s",
+            LogTag.c_str(),
+            session->GetClientId().c_str(),
+            session->GetSessionId().c_str(),
+            oldOwner.ToString().c_str());
     }
 
     if (oldOwner != owner) {
@@ -212,6 +226,13 @@ NActors::TActorId TIndexTabletState::RecoverSession(
         Impl->Sessions.PushBack(session);
 
         Impl->SessionByOwner.emplace(owner, session);
+
+        LOG_INFO(*TlsActivationContext, TFileStoreComponents::TABLET,
+            "%s added new owner for session c: %s, s: %s, owner: %s",
+            LogTag.c_str(),
+            session->GetClientId().c_str(),
+            session->GetSessionId().c_str(),
+            owner.ToString().c_str());
     }
 
     session->SetRecoveryTimestampUs(Now().MicroSeconds());
@@ -244,7 +265,7 @@ TSession* TIndexTabletState::FindSession(
     const TString& sessionId,
     ui64 seqNo) const
 {
-    auto session = FindSession(sessionId);
+    auto* session = FindSession(sessionId);
     if (session &&
         session->IsValid() &&
         session->GetClientId() == clientId &&
@@ -266,10 +287,11 @@ void TIndexTabletState::OrphanSession(const TActorId& owner, TInstant deadline)
     auto* session = it->second;
 
     LOG_INFO(*TlsActivationContext, TFileStoreComponents::TABLET,
-        "%s orphaning session c: %s, s: %s",
+        "%s orphaning session c: %s, s: %s, owner: %s",
         LogTag.c_str(),
         session->GetClientId().c_str(),
-        session->GetSessionId().c_str());
+        session->GetSessionId().c_str(),
+        owner.ToString().c_str());
 
     if (!session->DeleteSubSession(owner)) {
         session->Deadline = deadline;
@@ -278,6 +300,13 @@ void TIndexTabletState::OrphanSession(const TActorId& owner, TInstant deadline)
         Impl->OrphanSessions.PushBack(session);
 
         Impl->SessionByOwner.erase(it);
+
+        LOG_INFO(*TlsActivationContext, TFileStoreComponents::TABLET,
+            "%s removed last owner for session c: %s, s: %s, owner: %s",
+            LogTag.c_str(),
+            session->GetClientId().c_str(),
+            session->GetSessionId().c_str(),
+            owner.ToString().c_str());
     }
 }