Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx restoration shadow disk from backup #2934

Merged
merged 2 commits into from
Jan 28, 2025
Merged

FIx restoration shadow disk from backup #2934

merged 2 commits into from
Jan 28, 2025

Conversation

drbasic
Copy link
Collaborator

@drbasic drbasic commented Jan 28, 2025 •
edited
Loading

When restoring from backup, shadow disks are deleted, this is normal, since the backup may be old.

  1. corrected the warning message
  2. The shadow disk in the volume will immediately go into error state as soon as there disk registry restarted

@drbasic drbasic added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1db6c3d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3594 3592 0 2 0 0

@drbasic drbasic force-pushed the users/drbasic/fix-shadow-disk-from-backup-restore branch from 1db6c3d to c2269a0 Compare January 28, 2025 08:21
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c2269a0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3595 3595 0 0 0 0

agalibin
agalibin previously approved these changes Jan 28, 2025
View reviewed changes
tpashkin
tpashkin previously approved these changes Jan 28, 2025
View reviewed changes
@drbasic drbasic dismissed stale reviews from tpashkin and agalibin via 63bb7f6 January 28, 2025 09:37
@drbasic drbasic requested review from agalibin and tpashkin January 28, 2025 09:46
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 63bb7f6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3595 3595 0 0 0 0

@drbasic drbasic merged commit ca6a2ee into main Jan 28, 2025
11 of 14 checks passed
@drbasic drbasic deleted the users/drbasic/fix-shadow-disk-from-backup-restore branch January 28, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpashkin tpashkin tpashkin approved these changes

@agalibin agalibin agalibin approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drbasic @tpashkin @agalibin