Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UTs to check mixed/fresh blocks when write batching is enabled; add ShouldBatchSmallWritesToFreshChannelIfThresholdNotExceeded test #2942

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Improve UTs to check mixed/fresh blocks when write batching is enabled; add ShouldBatchSmallWritesToFreshChannelIfThresholdNotExceeded test #2942

merged 1 commit into from
Jan 31, 2025

Conversation

agalibin
Copy link
Collaborator

If we write blocks not exceeded threshold and batching mode is enabled part of data can be written to mixed channel directly so need to check this scenario in UTs.

@agalibin agalibin added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Jan 29, 2025
@ya-ksgamora ya-ksgamora self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 77b5f91.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3602 0 2 0 0

@ya-ksgamora ya-ksgamora removed their assignment Jan 29, 2025
@agalibin agalibin force-pushed the users/agalibin/nbs-ut_improvement branch 2 times, most recently from dd9ee5a to 8e58cb4 Compare January 29, 2025 16:00
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 8e58cb4.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

@agalibin agalibin added the recheck Add this label to relaunch checks, it will be automatically removed label Jan 30, 2025
@github-actions github-actions bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8e58cb4.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3604 0 0 0 0

@agalibin agalibin force-pushed the users/agalibin/nbs-ut_improvement branch from 8e58cb4 to a65ce01 Compare January 30, 2025 12:45
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a65ce01.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3610 3610 0 0 0 0

@SvartMetal SvartMetal changed the title Improve UTs to check mixed blocks in batching write mode Improve UTs to check mixed/fresh blocks when write batching is enabled Jan 30, 2025
@SvartMetal SvartMetal changed the title Improve UTs to check mixed/fresh blocks when write batching is enabled Improve UTs to check mixed/fresh blocks when write batching is enabled; add ShouldBatchSmallWritesToFreshChannelIfThresholdNotExceeded test Jan 30, 2025
@agalibin agalibin merged commit 09cb4a5 into main Jan 31, 2025
11 of 14 checks passed
@agalibin agalibin deleted the users/agalibin/nbs-ut_improvement branch January 31, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbasic drbasic drbasic left review comments

@SvartMetal SvartMetal SvartMetal approved these changes

@ya-ksgamora ya-ksgamora ya-ksgamora approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agalibin @drbasic @SvartMetal @ya-ksgamora