tests of ttl utility functions on SS #12092

swalrus1 · 2024-11-28T11:05:20Z

No description provided.

github-actions · 2024-11-28T11:09:15Z

⚪ 2024-11-28 11:09:15 UTC Pre-commit check linux-x86_64-release-asan for aa2cd0b has started.
⚪ 2024-11-28 11:09:26 UTC Artifacts will be uploaded here
⚪ 2024-11-28 11:12:35 UTC ya make is running...
⚫ 2024-11-28 12:14:50 UTC Check cancelled

github-actions · 2024-11-28T11:09:18Z

⚪ 2024-11-28 11:09:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for aa2cd0b has started.
⚪ 2024-11-28 11:09:29 UTC Artifacts will be uploaded here
⚪ 2024-11-28 11:12:36 UTC ya make is running...
🟢 2024-11-28 12:03:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20935	19424	0	0	1395	116

🟢 2024-11-28 12:05:17 UTC Build successful.
🟢 2024-11-28 12:05:34 UTC ydbd size 2.5 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7680faa`	merge: `aa2cd0b`	diff	diff %
ydbd size	2 695 024 168 Bytes	2 695 027 872 Bytes	+3.6 KiB	+0.000%
ydbd stripped size	482 194 416 Bytes	482 194 864 Bytes	+448 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-28T12:16:27Z

⚪ 2024-11-28 12:16:27 UTC Pre-commit check linux-x86_64-release-asan for 75fdfb1 has started.
⚪ 2024-11-28 12:16:39 UTC Artifacts will be uploaded here
⚪ 2024-11-28 12:19:47 UTC ya make is running...
⚫ 2024-11-28 13:12:07 UTC Check cancelled

github-actions · 2024-11-28T12:16:47Z

⚪ 2024-11-28 12:16:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 75fdfb1 has started.
⚪ 2024-11-28 12:16:58 UTC Artifacts will be uploaded here
⚪ 2024-11-28 12:19:53 UTC ya make is running...
⚫ 2024-11-28 13:11:49 UTC Check cancelled

…ity-tests-ttl

github-actions · 2024-11-28T13:13:52Z

⚪ 2024-11-28 13:13:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for af438aa has started.
⚪ 2024-11-28 13:14:03 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:16:56 UTC ya make is running...
⚫ 2024-11-28 13:25:19 UTC Check cancelled

github-actions · 2024-11-28T13:13:55Z

⚪ 2024-11-28 13:13:54 UTC Pre-commit check linux-x86_64-release-asan for af438aa has started.
⚪ 2024-11-28 13:17:05 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:21:19 UTC ya make is running...
⚫ 2024-11-28 13:25:05 UTC Check cancelled

ijon

I would suggest incorporating tier index into the error messages (for example: "tier 1: missing ApplyAfterSeconds").
The user gives a sequence of tiers, and error message without accurate addressing wouldn't be that helpful (even if sequence dize is supposed to be small).

ydb/core/tx/schemeshard/common/validation.cpp

ijon · 2024-11-28T13:01:02Z

ydb/core/tx/schemeshard/common/validation.cpp

+            case NKikimrSchemeOp::TTTLSettings_TTier::kEvictToExternalStorage:
+                break;
+            case NKikimrSchemeOp::TTTLSettings_TTier::ACTION_NOT_SET:
+                errStr = "Unset tier action";


Message not in line with the other messages.
I would suggest "Missing Action in the tier".

ijon · 2024-11-28T13:01:38Z

ydb/core/tx/schemeshard/common/validation.cpp

-            errStr = "Only the last tier in TTL settings can have Delete action";
+        const auto& tier = ttlSettings.GetTiers(i);
+        if (!tier.HasApplyAfterSeconds()) {
+            errStr = "Missing ApplyAfterSeconds in a tier";


"in the tier"

github-actions · 2024-11-28T13:29:33Z

⚪ 2024-11-28 13:29:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfe1a5e has started.
⚪ 2024-11-28 13:29:45 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:32:42 UTC ya make is running...
🟡 2024-11-28 14:22:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20943	19430	0	5	1396	112

⚪ 2024-11-28 14:23:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-28 14:35:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
807 (only retried tests)	699	0	1	0	107

⚪ 2024-11-28 14:35:22 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-28 14:46:50 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
684 (only retried tests)	577	0	1	0	106

🟢 2024-11-28 14:46:59 UTC Build successful.
🟢 2024-11-28 14:47:20 UTC ydbd size 2.5 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `121d6ae`	merge: `dfe1a5e`	diff	diff %
ydbd size	2 686 272 520 Bytes	2 686 278 608 Bytes	+5.9 KiB	+0.000%
ydbd stripped size	482 185 840 Bytes	482 186 672 Bytes	+832 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-28T13:29:53Z

⚪ 2024-11-28 13:29:53 UTC Pre-commit check linux-x86_64-release-asan for dfe1a5e has started.
⚪ 2024-11-28 13:30:05 UTC Artifacts will be uploaded here
⚪ 2024-11-28 13:32:59 UTC ya make is running...
🟡 2024-11-28 14:39:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13259	13192	0	13	6	48

🟢 2024-11-28 14:40:09 UTC Build successful.
🟢 2024-11-28 14:40:37 UTC ydbd size 4.9 GiB changed* by +22.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `121d6ae`	merge: `dfe1a5e`	diff	diff %
ydbd size	5 280 435 872 Bytes	5 280 459 128 Bytes	+22.7 KiB	+0.000%
ydbd stripped size	1 361 147 792 Bytes	1 361 155 280 Bytes	+7.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-28T15:30:05Z

⚪ 2024-11-28 15:30:04 UTC Pre-commit check linux-x86_64-release-asan for 14e7f0b has started.
⚪ 2024-11-28 15:30:16 UTC Artifacts will be uploaded here
⚪ 2024-11-28 15:33:24 UTC ya make is running...
🟡 2024-11-28 16:47:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13259	13170	0	26	11	52

🟢 2024-11-28 16:48:13 UTC Build successful.
🟢 2024-11-28 16:48:43 UTC ydbd size 4.9 GiB changed* by +18.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `2f89980`	merge: `14e7f0b`	diff	diff %
ydbd size	5 281 015 488 Bytes	5 281 034 640 Bytes	+18.7 KiB	+0.000%
ydbd stripped size	1 361 303 664 Bytes	1 361 307 056 Bytes	+3.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-28T15:32:36Z

⚪ 2024-11-28 15:32:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 14e7f0b has started.
⚪ 2024-11-28 15:32:46 UTC Artifacts will be uploaded here
⚪ 2024-11-28 15:35:40 UTC ya make is running...
🟡 2024-11-28 16:23:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20944	19430	0	1	1397	116

⚪ 2024-11-28 16:25:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 16:37:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
825 (only retried tests)	715	0	0	0	110

🟢 2024-11-28 16:37:27 UTC Build successful.
🟢 2024-11-28 16:37:52 UTC ydbd size 2.5 GiB changed* by +6.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `2f89980`	merge: `14e7f0b`	diff	diff %
ydbd size	2 686 661 376 Bytes	2 686 667 480 Bytes	+6.0 KiB	+0.000%
ydbd stripped size	482 255 888 Bytes	482 256 720 Bytes	+832 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

tests of ttl utility functions on SS

f4ab4db

swalrus1 marked this pull request as ready for review November 28, 2024 12:05

nit

068a473

typo

00101c6

swalrus1 enabled auto-merge (squash) November 28, 2024 13:10

Merge branch 'utility-tests-ttl' of github.com:swalrus1/ydb into util…

8c005ad

…ity-tests-ttl

ijon reviewed Nov 28, 2024

View reviewed changes

change messages

f4e94a0

ijon previously approved these changes Nov 28, 2024

View reviewed changes

fix a test

36331ab

swalrus1 dismissed ijon’s stale review via 36331ab November 28, 2024 15:25

ijon approved these changes Nov 28, 2024

View reviewed changes

swalrus1 merged commit eace3cb into ydb-platform:main Nov 28, 2024
10 checks passed

swalrus1 deleted the utility-tests-ttl branch November 28, 2024 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests of ttl utility functions on SS #12092

tests of ttl utility functions on SS #12092

swalrus1 commented Nov 28, 2024

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

ijon left a comment

ijon Nov 28, 2024

ijon Nov 28, 2024

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

tests of ttl utility functions on SS #12092

tests of ttl utility functions on SS #12092

Conversation

swalrus1 commented Nov 28, 2024

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

ijon left a comment

Choose a reason for hiding this comment

ijon Nov 28, 2024

Choose a reason for hiding this comment

ijon Nov 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024 •

edited

Loading