Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping service #12100

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ping service #12100

wants to merge 3 commits into from

Conversation

eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 13:49:09 UTC Pre-commit check linux-x86_64-release-asan for 93bf67a has started.
2024-11-28 13:49:52 UTC Artifacts will be uploaded here
2024-11-28 13:53:50 UTC ya make is running...
🟡 2024-11-28 15:31:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15766 15691 0 19 6 50

🟢 2024-11-28 15:32:36 UTC Build successful.
🔴 2024-11-28 15:33:05 UTC ydbd size 4.9 GiB changed* by +5.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 121d6ae merge: 93bf67a diff diff %
ydbd size 5 280 435 872 Bytes 5 286 207 976 Bytes +5.5 MiB +0.109%
ydbd stripped size 1 361 147 792 Bytes 1 362 806 288 Bytes +1.6 MiB +0.122%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 13:50:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 93bf67a has started.
2024-11-28 13:50:58 UTC Artifacts will be uploaded here
2024-11-28 13:54:26 UTC ya make is running...
🟡 2024-11-28 15:27:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
33204 30360 0 3 2720 121

2024-11-28 15:30:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 15:42:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
918 (only retried tests) 811 0 0 0 107

🟢 2024-11-28 15:42:35 UTC Build successful.
🔴 2024-11-28 15:42:55 UTC ydbd size 2.5 GiB changed* by +2.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 121d6ae merge: 93bf67a diff diff %
ydbd size 2 686 272 520 Bytes 2 689 047 384 Bytes +2.6 MiB +0.103%
ydbd stripped size 482 185 840 Bytes 482 672 400 Bytes +475.2 KiB +0.101%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation


void Proceed(const TActorContext &ctx) {
LOG_TRACE_S(ctx, NKikimrServices::RPC_REQUEST, this->SelfId() << " sending ping to TxProxy");
if (!ctx.Send(MakeTxProxyID(), new TEvTxUserProxy::TEvAllocateTxId)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Наверно, лучше отправлять EvGetProxyServicesRequest. Иначе, если слишком часто пинговать, можно истощить запас tx id-ов.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants