don't invalidate snapshot immediately after scan is finished #12257

swalrus1 · 2024-12-03T16:31:32Z

No description provided.

github-actions · 2024-12-03T16:34:51Z

⚪ 2024-12-03 16:34:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for bfa34d3 has started.
⚪ 2024-12-03 16:35:01 UTC Artifacts will be uploaded here
⚪ 2024-12-03 16:37:57 UTC ya make is running...
🟡 2024-12-03 17:30:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20635	19122	0	2	1396	115

⚪ 2024-12-03 17:32:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-03 17:43:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
752 (only retried tests)	644	0	2	0	106

⚪ 2024-12-03 17:43:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-03 17:55:15 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
674 (only retried tests)	567	0	2	0	105

🟢 2024-12-03 17:55:24 UTC Build successful.
🟢 2024-12-03 17:55:44 UTC ydbd size 2.5 GiB changed* by -14.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `5c8e3e6`	merge: `bfa34d3`	diff	diff %
ydbd size	2 692 966 544 Bytes	2 692 952 032 Bytes	-14.2 KiB	-0.001%
ydbd stripped size	483 580 720 Bytes	483 578 352 Bytes	-2.3 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-03T16:35:32Z

⚪ 2024-12-03 16:35:32 UTC Pre-commit check linux-x86_64-release-asan for bfa34d3 has started.
⚪ 2024-12-03 16:35:43 UTC Artifacts will be uploaded here
⚪ 2024-12-03 16:38:36 UTC ya make is running...
🟡 2024-12-03 17:43:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13121	13043	0	22	10	46

🟢 2024-12-03 17:44:20 UTC Build successful.
🟢 2024-12-03 17:44:48 UTC ydbd size 4.9 GiB changed* by -31.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `5c8e3e6`	merge: `bfa34d3`	diff	diff %
ydbd size	5 293 690 264 Bytes	5 293 657 744 Bytes	-31.8 KiB	-0.001%
ydbd stripped size	1 365 550 448 Bytes	1 365 543 728 Bytes	-6.6 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T11:13:08Z

⚪ 2024-12-04 11:13:07 UTC Pre-commit check linux-x86_64-release-asan for 2449e29 has started.
⚪ 2024-12-04 11:13:20 UTC Artifacts will be uploaded here
⚪ 2024-12-04 11:16:27 UTC ya make is running...
🟡 2024-12-04 12:50:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13123	13048	0	19	9	47

🟢 2024-12-04 12:51:58 UTC Build successful.
🟢 2024-12-04 12:52:30 UTC ydbd size 4.9 GiB changed* by +8.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d7df471`	merge: `2449e29`	diff	diff %
ydbd size	5 308 357 800 Bytes	5 308 366 408 Bytes	+8.4 KiB	+0.000%
ydbd stripped size	1 365 621 584 Bytes	1 365 623 312 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T11:15:11Z

⚪ 2024-12-04 11:15:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2449e29 has started.
⚪ 2024-12-04 11:15:22 UTC Artifacts will be uploaded here
⚪ 2024-12-04 11:18:17 UTC ya make is running...
🟡 2024-12-04 12:10:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20637	18965	0	2	1624	46

⚪ 2024-12-04 12:12:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-04 12:24:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
829 (only retried tests)	715	0	0	8	106

🟢 2024-12-04 12:24:50 UTC Build successful.
🟢 2024-12-04 12:25:09 UTC ydbd size 2.5 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d7df471`	merge: `2449e29`	diff	diff %
ydbd size	2 701 815 712 Bytes	2 701 818 560 Bytes	+2.8 KiB	+0.000%
ydbd stripped size	483 605 200 Bytes	483 605 776 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T15:09:28Z

⚪ 2024-12-04 15:09:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 515e642 has started.
⚪ 2024-12-04 15:09:38 UTC Artifacts will be uploaded here
⚪ 2024-12-04 15:12:32 UTC ya make is running...
🟡 2024-12-04 16:02:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20622	19112	0	2	1396	112

⚪ 2024-12-04 16:03:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-04 16:15:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
720 (only retried tests)	615	0	0	0	105

🟢 2024-12-04 16:15:45 UTC Build successful.
🟢 2024-12-04 16:16:02 UTC ydbd size 2.5 GiB changed* by +2.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f34c1a`	merge: `515e642`	diff	diff %
ydbd size	2 702 464 680 Bytes	2 702 467 288 Bytes	+2.5 KiB	+0.000%
ydbd stripped size	483 670 512 Bytes	483 671 088 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T15:11:01Z

⚪ 2024-12-04 15:11:00 UTC Pre-commit check linux-x86_64-release-asan for 515e642 has started.
⚪ 2024-12-04 15:11:14 UTC Artifacts will be uploaded here
⚪ 2024-12-04 15:14:22 UTC ya make is running...
🟡 2024-12-04 16:23:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13136	13057	0	28	6	45

🟢 2024-12-04 16:24:10 UTC Build successful.
🟢 2024-12-04 16:24:37 UTC ydbd size 4.9 GiB changed* by +7.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f34c1a`	merge: `515e642`	diff	diff %
ydbd size	5 309 573 408 Bytes	5 309 581 184 Bytes	+7.6 KiB	+0.000%
ydbd stripped size	1 365 834 672 Bytes	1 365 836 208 Bytes	+1.5 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T16:29:38Z

⚪ 2024-12-04 16:29:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for a4a8499 has started.
⚪ 2024-12-04 16:29:49 UTC Artifacts will be uploaded here
⚪ 2024-12-04 16:32:48 UTC ya make is running...
🟡 2024-12-04 17:33:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20653	19135	0	1	1397	120

⚪ 2024-12-04 17:35:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-04 17:47:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
783 (only retried tests)	676	0	0	0	107

🟢 2024-12-04 17:47:40 UTC Build successful.
🟢 2024-12-04 17:48:00 UTC ydbd size 2.5 GiB changed* by +82.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b2da93a`	merge: `a4a8499`	diff	diff %
ydbd size	2 699 533 352 Bytes	2 699 617 576 Bytes	+82.2 KiB	+0.003%
ydbd stripped size	483 498 160 Bytes	483 505 392 Bytes	+7.1 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T16:31:46Z

⚪ 2024-12-04 16:31:46 UTC Pre-commit check linux-x86_64-release-asan for a4a8499 has started.
⚪ 2024-12-04 16:31:58 UTC Artifacts will be uploaded here
⚪ 2024-12-04 16:34:54 UTC ya make is running...
🟡 2024-12-04 18:01:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13137	13066	0	20	6	45

🟢 2024-12-04 18:02:35 UTC Build successful.
🟢 2024-12-04 18:03:04 UTC ydbd size 4.9 GiB changed* by +64.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b2da93a`	merge: `a4a8499`	diff	diff %
ydbd size	5 303 785 112 Bytes	5 303 851 152 Bytes	+64.5 KiB	+0.001%
ydbd stripped size	1 365 257 168 Bytes	1 365 280 944 Bytes	+23.2 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ivanmorozov333 · 2024-12-04T17:35:07Z

ydb/core/tx/columnshard/inflight_request_tracker.h

-                return true;
-            }
+        }
+        if (critDuration < *LastPingInstant - Snapshot.GetPlanInstant() && !IsLock) {


что-то я не уверен, что нужно блокировать snapshot если requests пустой... получается, что блокировка будет всегда... то есть, мы потрогали snapshot, прошло 5 минут, мы его залочили, судя по всему... то есть, надо придумать вариант на тему того как чистить, если лока не было.
кажется, что нужно, просто, убрать условие IsLock в 57-й строке и не убирать else

swalrus1 linked an issue Dec 4, 2024 that may be closed by this pull request

Snapshots are occasionally invalidated on long scans on CS #12270

Closed

fix

b1b90eb

swalrus1 force-pushed the fix-snapshot-invalidation branch from 3eac152 to b1b90eb Compare December 4, 2024 11:10

swalrus1 marked this pull request as ready for review December 4, 2024 15:01

swalrus1 requested a review from a team as a code owner December 4, 2024 15:01

swalrus1 added 2 commits December 4, 2024 15:01

clean up

86dcb2d

clean up

5ac2654

ivanmorozov333 previously approved these changes Dec 4, 2024

View reviewed changes

fix

1e88f78

swalrus1 dismissed ivanmorozov333’s stale review via 1e88f78 December 4, 2024 16:27

ivanmorozov333 reviewed Dec 4, 2024

View reviewed changes

swalrus1 closed this Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't invalidate snapshot immediately after scan is finished #12257

don't invalidate snapshot immediately after scan is finished #12257

swalrus1 commented Dec 3, 2024

github-actions bot commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

ivanmorozov333 Dec 4, 2024

don't invalidate snapshot immediately after scan is finished #12257

don't invalidate snapshot immediately after scan is finished #12257

Conversation

swalrus1 commented Dec 3, 2024

github-actions bot commented Dec 3, 2024 • edited Loading

github-actions bot commented Dec 3, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

ivanmorozov333 Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading