YQ-3836 improved metadata objects errors #12486

GrigoriyPA · 2024-12-11T08:24:30Z

Changelog entry

Improved metadata objects errors

Changelog category

Improvement

Additional information

github-actions · 2024-12-11T08:25:52Z

⚪ 2024-12-11 08:25:51 UTC Pre-commit check linux-x86_64-release-asan for e1ccbdd has started.
⚪ 2024-12-11 08:26:02 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:29:05 UTC ya make is running...
⚫ 2024-12-11 08:29:43 UTC Check cancelled

github-actions · 2024-12-11T08:28:14Z

⚪ 2024-12-11 08:28:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for e1ccbdd has started.
⚪ 2024-12-11 08:28:24 UTC Artifacts will be uploaded here
⚫ 2024-12-11 08:29:41 UTC Check cancelled

github-actions · 2024-12-11T08:33:45Z

⚪ 2024-12-11 08:33:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0c40793 has started.
⚪ 2024-12-11 08:33:56 UTC Artifacts will be uploaded here
⚫ 2024-12-11 08:37:15 UTC Check cancelled

github-actions · 2024-12-11T08:34:13Z

⚪ 2024-12-11 08:34:13 UTC Pre-commit check linux-x86_64-release-asan for 0c40793 has started.
⚪ 2024-12-11 08:34:24 UTC Artifacts will be uploaded here
⚫ 2024-12-11 08:37:27 UTC Check cancelled

github-actions · 2024-12-11T08:38:51Z

⚪ 2024-12-11 08:38:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for a494802 has started.
⚪ 2024-12-11 08:38:55 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:42:12 UTC ya make is running...
⚫ 2024-12-11 08:46:44 UTC Check cancelled

github-actions · 2024-12-11T08:38:58Z

⚪ 2024-12-11 08:38:57 UTC Pre-commit check linux-x86_64-release-asan for a494802 has started.
⚪ 2024-12-11 08:39:07 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:42:13 UTC ya make is running...
⚫ 2024-12-11 08:46:44 UTC Check cancelled

github-actions · 2024-12-11T08:48:40Z

⚪ 2024-12-11 08:48:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for d60ed80 has started.
⚪ 2024-12-11 08:48:52 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:51:56 UTC ya make is running...
⚫ 2024-12-11 08:52:41 UTC Check cancelled

github-actions · 2024-12-11T08:49:51Z

⚪ 2024-12-11 08:49:50 UTC Pre-commit check linux-x86_64-release-asan for d60ed80 has started.
⚪ 2024-12-11 08:50:02 UTC Artifacts will be uploaded here
⚫ 2024-12-11 08:52:40 UTC Check cancelled

github-actions · 2024-12-11T08:54:33Z

⚪ 2024-12-11 08:54:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 724a51f has started.
⚪ 2024-12-11 08:55:09 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:58:42 UTC ya make is running...
🟡 2024-12-11 10:23:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32521	29596	0	4	2810	111

⚪ 2024-12-11 10:26:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 10:39:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
656 (only retried tests)	547	0	1	1	107

⚪ 2024-12-11 10:39:13 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 10:50:51 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
638 (only retried tests)	530	0	1	0	107

🟢 2024-12-11 10:51:01 UTC Build successful.
🟢 2024-12-11 10:51:21 UTC ydbd size 2.1 GiB changed* by +21.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `961df40`	merge: `724a51f`	diff	diff %
ydbd size	2 255 623 720 Bytes	2 255 645 968 Bytes	+21.7 KiB	+0.001%
ydbd stripped size	483 851 728 Bytes	483 867 792 Bytes	+15.7 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T08:54:49Z

⚪ 2024-12-11 08:54:48 UTC Pre-commit check linux-x86_64-release-asan for 724a51f has started.
⚪ 2024-12-11 08:55:00 UTC Artifacts will be uploaded here
⚪ 2024-12-11 08:58:03 UTC ya make is running...
🟡 2024-12-11 10:30:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15103	15034	0	20	4	45

🟢 2024-12-11 10:31:35 UTC Build successful.
🟢 2024-12-11 10:32:01 UTC ydbd size 3.6 GiB changed* by +77.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `961df40`	merge: `724a51f`	diff	diff %
ydbd size	3 897 522 304 Bytes	3 897 601 504 Bytes	+77.3 KiB	+0.002%
ydbd stripped size	1 366 453 872 Bytes	1 366 504 688 Bytes	+49.6 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/kqp/gateway/behaviour/external_data_source/manager.cpp

ydb/services/metadata/abstract/request_features.cpp

dorooleg · 2024-12-13T12:39:44Z

ydb/core/kqp/gateway/behaviour/external_data_source/manager.cpp

-    if (!AppData(actorSystem)->FeatureFlags.GetEnableExternalDataSources()) {
-        throw std::runtime_error("External data sources are disabled. Please contact your system administrator to enable it");
-    }
+TString GetOrEmpty(const NYql::TCreateObjectSettings& container, const TString& key) {


Похоже в этом ревью все намешалось:

Рефакторинг

Не печатать строчку кода в пользовательские ошибки

Изменение возвращаемых статусов

Да, рефакторинг я ещё хотел сделать, когда добавлял resource_pool, так как тогда вышло довольно много копипасты, сейчас её постарался убрать + убрал throw и большинства мест, чтобы не отловленное исключение мапилось в INTERNAL_ERROR, а в остальных местах явно бы прописывался статус ошибки

github-actions · 2024-12-23T11:08:40Z

⚪ 2024-12-23 11:08:40 UTC Pre-commit check linux-x86_64-release-asan for 94e95ed has started.
⚪ 2024-12-23 11:08:52 UTC Artifacts will be uploaded here
⚪ 2024-12-23 11:11:53 UTC ya make is running...
⚫ 2024-12-23 11:55:26 UTC Check cancelled

github-actions · 2024-12-23T11:08:56Z

⚪ 2024-12-23 11:08:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 94e95ed has started.
⚪ 2024-12-23 11:09:06 UTC Artifacts will be uploaded here
⚪ 2024-12-23 11:12:06 UTC ya make is running...
⚫ 2024-12-23 11:55:28 UTC Check cancelled

github-actions · 2024-12-23T11:56:05Z

⚪ 2024-12-23 11:56:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 76ab0cf has started.
⚪ 2024-12-23 11:56:08 UTC Artifacts will be uploaded here
⚪ 2024-12-23 11:59:17 UTC ya make is running...
🟡 2024-12-23 12:59:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
30749	27803	0	2	2831	113

⚪ 2024-12-23 13:02:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-23 13:14:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
158 (only retried tests)	49	0	0	0	109

🟢 2024-12-23 13:14:20 UTC Build successful.
🟢 2024-12-23 13:14:41 UTC ydbd size 2.1 GiB changed* by -40.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `1e172ec`	merge: `76ab0cf`	diff	diff %
ydbd size	2 234 949 880 Bytes	2 234 908 000 Bytes	-40.9 KiB	-0.002%
ydbd stripped size	477 965 520 Bytes	477 955 024 Bytes	-10.2 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-23T11:56:15Z

⚪ 2024-12-23 11:56:15 UTC Pre-commit check linux-x86_64-release-asan for 76ab0cf has started.
⚪ 2024-12-23 11:56:45 UTC Artifacts will be uploaded here
⚪ 2024-12-23 12:00:23 UTC ya make is running...
🟡 2024-12-23 13:04:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13855	13777	0	21	10	47

🟢 2024-12-23 13:06:05 UTC Build successful.
🟢 2024-12-23 13:06:29 UTC ydbd size 3.6 GiB changed* by -40.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `1e172ec`	merge: `76ab0cf`	diff	diff %
ydbd size	3 865 485 568 Bytes	3 865 444 000 Bytes	-40.6 KiB	-0.001%
ydbd stripped size	1 350 611 152 Bytes	1 350 602 576 Bytes	-8.4 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions bot added the new-feature label Dec 11, 2024

GrigoriyPA requested a review from dorooleg December 11, 2024 08:25

github-actions bot added improvement and removed new-feature labels Dec 11, 2024

dorooleg requested changes Dec 13, 2024

View reviewed changes

GrigoriyPA added 6 commits December 23, 2024 11:04

Fixed metadata objects errors

e7aec05

Fixed unit tests 1

6dd7960

Fixed unit tests 2

ce28cf2

Fixed unit tests 3

62c6c12

Fixed unit tests 4

5377056

Fixed ErrorFromActivityType

9e617a4

GrigoriyPA force-pushed the YQ-3836-improve-metadata-objects-errors branch from 1000bdf to 9e617a4 Compare December 23, 2024 11:07

GrigoriyPA requested a review from dorooleg December 23, 2024 11:29

Fixed typo

2ad3dd8

dorooleg approved these changes Dec 25, 2024

View reviewed changes

GrigoriyPA merged commit db73603 into ydb-platform:main Dec 27, 2024
10 checks passed

GrigoriyPA deleted the YQ-3836-improve-metadata-objects-errors branch December 27, 2024 06:18

GrigoriyPA mentioned this pull request Jan 5, 2025

KqpRun improved multi query mode and storage settings #13177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YQ-3836 improved metadata objects errors #12486

YQ-3836 improved metadata objects errors #12486

GrigoriyPA commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

dorooleg Dec 13, 2024

GrigoriyPA Dec 23, 2024

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

YQ-3836 improved metadata objects errors #12486

YQ-3836 improved metadata objects errors #12486

Conversation

GrigoriyPA commented Dec 11, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

dorooleg Dec 13, 2024

Choose a reason for hiding this comment

GrigoriyPA Dec 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

GrigoriyPA commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading