Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbs-issue-176: added EncryptedDataKey field to NKikimrBlockStore::TEncryptionDesc #8482

Conversation

sharpeye
Copy link
Contributor

@sharpeye sharpeye commented Aug 29, 2024

This PR relates to ydb-platform/nbs#176

The EncryptedDataKey field is added to TEncryptionDesc to store the encrypted data encryption key.

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 14:53:40 UTC Pre-commit check linux-x86_64-release-clang14 for 83f0878 has started.
2024-08-29 14:56:52 UTC ya make is running...
2024-08-29 14:59:09 UTC Check cancelled

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 14:55:23 UTC Pre-commit check linux-x86_64-release-asan for 83f0878 has started.
2024-08-29 14:58:28 UTC ya make is running...
2024-08-29 14:59:09 UTC Check cancelled

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 14:55:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 83f0878 has started.
2024-08-29 14:58:29 UTC ya make is running...
2024-08-29 14:59:09 UTC Check cancelled

@sharpeye sharpeye force-pushed the users/sharpeye/nbs-issue-176-add-encrypted-dek-field branch from e79a52c to 9703564 Compare August 29, 2024 14:58
Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:01:15 UTC Pre-commit check linux-x86_64-release-clang14 for faed847 has started.
2024-08-29 15:05:21 UTC ya make is running...
🔴 2024-08-29 15:07:31 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:01:21 UTC Pre-commit check linux-x86_64-release-asan for faed847 has started.
2024-08-29 15:04:27 UTC ya make is running...
🔴 2024-08-29 15:08:55 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:03:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for faed847 has started.
2024-08-29 15:06:55 UTC ya make is running...
🔴 2024-08-29 15:09:31 UTC Build failed. see the logs.

@sharpeye sharpeye force-pushed the users/sharpeye/nbs-issue-176-add-encrypted-dek-field branch from 9703564 to 8598f86 Compare August 29, 2024 15:25
Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:27:32 UTC Pre-commit check linux-x86_64-release-asan for 78a9868 has started.
2024-08-29 15:31:27 UTC ya make is running...
🔴 2024-08-29 17:31:42 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11463 11400 0 17 25 21

🟢 2024-08-29 17:32:44 UTC Build successful.
🟢 2024-08-29 17:33:21 UTC ydbd size 5.5 GiB changed* by +71.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 93089ee merge: 78a9868 diff diff %
ydbd size 5 944 034 864 Bytes 5 944 108 504 Bytes +71.9 KiB +0.001%
ydbd stripped size 1 492 622 160 Bytes 1 492 639 408 Bytes +16.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:27:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78a9868 has started.
2024-08-29 15:30:59 UTC ya make is running...
🟡 2024-08-29 17:03:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40666 35274 0 7 5364 21

2024-08-29 17:06:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-08-29 17:16:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 21 0 0 0 13

🟢 2024-08-29 17:16:42 UTC Build successful.
🟢 2024-08-29 17:17:19 UTC ydbd size 8.2 GiB changed* by +73.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 93089ee merge: 78a9868 diff diff %
ydbd size 8 818 949 792 Bytes 8 819 025 504 Bytes +73.9 KiB +0.001%
ydbd stripped size 480 823 560 Bytes 480 827 912 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 29, 2024

2024-08-29 15:27:52 UTC Pre-commit check linux-x86_64-release-clang14 for 78a9868 has started.
2024-08-29 15:31:04 UTC ya make is running...
🟢 2024-08-29 16:17:25 UTC Build successful.

@sharpeye sharpeye marked this pull request as ready for review August 29, 2024 18:59
@sharpeye sharpeye force-pushed the users/sharpeye/nbs-issue-176-add-encrypted-dek-field branch from 8598f86 to 7295fe9 Compare September 3, 2024 08:43
Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 08:46:27 UTC Pre-commit check linux-x86_64-release-asan for b92f39c has started.
2024-09-03 08:49:37 UTC ya make is running...
🔴 2024-09-03 11:02:41 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11510 11426 0 25 33 26

🟢 2024-09-03 11:03:41 UTC Build successful.
🟢 2024-09-03 11:04:13 UTC ydbd size 5.5 GiB changed* by +79.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 69a5707 merge: b92f39c diff diff %
ydbd size 5 954 134 264 Bytes 5 954 215 272 Bytes +79.1 KiB +0.001%
ydbd stripped size 1 489 375 920 Bytes 1 489 393 232 Bytes +16.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 08:46:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for b92f39c has started.
2024-09-03 08:50:00 UTC ya make is running...
🟡 2024-09-03 10:37:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40754 35329 0 3 5402 20

2024-09-03 10:41:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-03 10:51:12 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
33 (only retried tests) 16 0 0 1 16

🟢 2024-09-03 10:51:19 UTC Build successful.
🟢 2024-09-03 10:51:56 UTC ydbd size 8.3 GiB changed* by +89.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 69a5707 merge: b92f39c diff diff %
ydbd size 8 917 967 584 Bytes 8 918 059 448 Bytes +89.7 KiB +0.001%
ydbd stripped size 481 779 976 Bytes 481 788 424 Bytes +8.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 3, 2024

2024-09-03 08:47:16 UTC Pre-commit check linux-x86_64-release-clang14 for b92f39c has started.
2024-09-03 08:50:28 UTC ya make is running...
🟢 2024-09-03 09:44:16 UTC Build successful.

@sharpeye sharpeye marked this pull request as draft September 3, 2024 09:53
@sharpeye sharpeye force-pushed the users/sharpeye/nbs-issue-176-add-encrypted-dek-field branch from 7295fe9 to 39c3da7 Compare December 3, 2024 17:47
@sharpeye sharpeye changed the title nbs-issue-176: added TEncryptedDEK field to TEncryptionDesc nbs-issue-176: added EncryptedDataKey field to TEncryptionDesc Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 17:50:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7db72d has started.
2024-12-03 17:50:56 UTC Artifacts will be uploaded here
2024-12-03 17:54:11 UTC ya make is running...
🟡 2024-12-03 19:25:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32666 29834 0 4 2719 109

2024-12-03 19:28:08 UTC ya make is running... (failed tests rerun, try 2)

Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 17:52:21 UTC Pre-commit check linux-x86_64-release-asan for c7db72d has started.
2024-12-03 17:52:34 UTC Artifacts will be uploaded here
2024-12-03 17:56:04 UTC ya make is running...

@sharpeye sharpeye changed the title nbs-issue-176: added EncryptedDataKey field to TEncryptionDesc nbs-issue-176: added EncryptedDataKey field to NKikimrBlockStore::TEncryptionDesc Dec 4, 2024
@sharpeye sharpeye marked this pull request as ready for review December 4, 2024 12:00
@va-kuznecov va-kuznecov enabled auto-merge (squash) December 4, 2024 14:49
@va-kuznecov va-kuznecov added the rebase-and-check Rebase PR with the current main and check label Dec 4, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 16:11:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90b781e has started.
2024-12-04 16:11:20 UTC Artifacts will be uploaded here
2024-12-04 16:14:40 UTC ya make is running...
🟢 2024-12-04 17:44:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32684 29854 0 0 2719 111

🟢 2024-12-04 17:46:59 UTC Build successful.
🟢 2024-12-04 17:47:17 UTC ydbd size 2.5 GiB changed* by +25.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b2da93a merge: 90b781e diff diff %
ydbd size 2 699 533 352 Bytes 2 699 558 984 Bytes +25.0 KiB +0.001%
ydbd stripped size 483 498 160 Bytes 483 502 512 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 16:12:12 UTC Pre-commit check linux-x86_64-release-asan for 90b781e has started.
2024-12-04 16:12:22 UTC Artifacts will be uploaded here
2024-12-04 16:15:38 UTC ya make is running...
🟡 2024-12-04 17:53:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15229 15158 0 20 6 45

🟢 2024-12-04 17:54:43 UTC Build successful.
🟢 2024-12-04 17:55:12 UTC ydbd size 4.9 GiB changed* by +49.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b2da93a merge: 90b781e diff diff %
ydbd size 5 303 785 112 Bytes 5 303 835 520 Bytes +49.2 KiB +0.001%
ydbd stripped size 1 365 257 168 Bytes 1 365 270 320 Bytes +12.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov merged commit e6985bf into ydb-platform:main Dec 4, 2024
15 of 18 checks passed
@sharpeye sharpeye deleted the users/sharpeye/nbs-issue-176-add-encrypted-dek-field branch December 4, 2024 19:33
sharpeye added a commit to sharpeye/ydb that referenced this pull request Dec 10, 2024
maximyurchuk pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants