Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dyfi redemption chart to veyfi.md #389

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

rossgalloway
Copy link
Collaborator

Added the chart shown in #372 to the veYFI page under contribute/governance.

Comments:

  • Original image from the issue was private and could not be saved. What I added is a screenshot of it. I can update the image if given access to the original, although I don't really think it makes a difference.
  • There is some automatic linting going on when I make changes (markdownlint plugin defaults). I don't think the changes are breaking the style guide but happy to adjust if this is a problem.

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearn-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 11:05pm

@@ -6,7 +6,7 @@ Contract Address: [`0x90c1f9220d90d3966fbee24045edd73e1d588ad5`](https://ethersc

## Specification

Governance Forum Thread: https://gov.yearn.fi/t/yip-65-evolving-yfi-tokenomics
Governance Forum Thread: <https://gov.yearn.fi/t/yip-65-evolving-yfi-tokenomics>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove the <> around links? we don't have this standard in the other pages of the docs!

@MarcoWorms
Copy link
Collaborator

dead link is a false positive

Co-authored-by: Marco Guaspari Worms <[email protected]>
Copy link
Collaborator

@MarcoWorms MarcoWorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarcoWorms MarcoWorms merged commit 36d0360 into yearn:master Dec 14, 2023
@rossgalloway rossgalloway deleted the add-dYFI-graphic-#372 branch December 15, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants