Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update parent sign up error dialog and remove back button post-submission #1026

Merged
merged 12 commits into from
Feb 12, 2025
Merged

update parent sign up error dialog and remove back button post-submission #1026

merged 12 commits into from
Feb 12, 2025
+3 −3

Conversation

lucasxsong
Copy link
Collaborator

@lucasxsong lucasxsong commented Feb 4, 2025 •
edited
Loading

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@lucasxsong lucasxsong requested a review from a team as a code owner February 4, 2025 19:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1363 for commit a71d933 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit a71d933):

https://roar-staging--pr1026-fix-parent-signup-fi-gwo6q8yq.web.app

(expires Wed, 19 Feb 2025 19:27:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@cypress Cypress
Copy link

cypress bot commented Feb 4, 2025 •
edited
Loading

roar-dashboard-e2e    Run #10994

Run Properties:  status check passed Passed #10994  •  git commit a71d933bd7: Component Tests for PR 1026 "update parent sign up error dialog and remove back ...
Project roar-dashboard-e2e
Branch Review fix/parent-signup-fixes
Run status status check passed Passed #10994
Run duration 01m 56s
Commit git commit a71d933bd7: Component Tests for PR 1026 "update parent sign up error dialog and remove back ...
Committer Ⓛucas son 🇬
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 68
View all changes introduced in this branch ↗︎

@Emily-ejag Emily-ejag added the bug Something isn't working label Feb 5, 2025
@lucasxsong lucasxsong changed the title update parent sign up error dialog update parent sign up error dialog and remove back button post-submission Feb 6, 2025
Emily-ejag
Emily-ejag previously approved these changes Feb 10, 2025
View reviewed changes
maximilianoertel
maximilianoertel requested changes Feb 11, 2025
View reviewed changes
src/components/auth/RegisterChildren.vue Outdated Show resolved Hide resolved
src/components/auth/RegisterChildren.vue Outdated Show resolved Hide resolved
src/pages/RegisterFamilyUsers.vue Outdated
@@ -40,7 +40,7 @@
</div>
</header>
<div>
<div v-if="activeIndex === 1">
<div v-if="activeIndex === 1 && spinner !== true">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, spinner !== true can be simplified to !spinner for better readability

Suggested change
<div v-if="activeIndex === 1 && spinner !== true">
<div v-if="activeIndex === 1 && !spinner">

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, in terms of UX, it would be better to disable the button instead of removing to avoid layout shifts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use the loading and loadingIcon property of PvButton (see https://primevue.org/button/#api.button.props.loading).

richford
richford requested changes Feb 11, 2025
View reviewed changes
src/pages/RegisterFamilyUsers.vue Outdated
@@ -40,7 +40,7 @@
</div>
</header>
<div>
<div v-if="activeIndex === 1">
<div v-if="activeIndex === 1 && spinner !== true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use the loading and loadingIcon property of PvButton (see https://primevue.org/button/#api.button.props.loading).

maximilianoertel
maximilianoertel approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@maximilianoertel maximilianoertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucasxsong lucasxsong merged commit e3a1243 into main Feb 12, 2025
21 of 24 checks passed
@lucasxsong lucasxsong deleted the fix/parent-signup-fixes branch February 12, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richford richford richford requested changes

@maximilianoertel maximilianoertel maximilianoertel approved these changes

@Emily-ejag Emily-ejag Emily-ejag approved these changes

@kellyel kellyel kellyel approved these changes

Assignees

@lucasxsong lucasxsong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasxsong @maximilianoertel @richford @Emily-ejag @kellyel