Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feat/project-config from main #1037

Open
wants to merge 16 commits into
base: feat/project-config
Choose a base branch
from

Conversation

maximilianoertel
Copy link
Collaborator

@maximilianoertel maximilianoertel commented Feb 12, 2025

Proposed changes

This PR updates the feat/project-config feature branch with the latest changes from the main branch. This ensures that the feature branch is up-to-date with the latest codebase before continuing development.

Additionally, as the rebase includes changes to the Firebase hosting configuration which uses deploy targets, this PR also updates the CI workflows to support those accordingly.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Emily-ejag and others added 12 commits January 31, 2025 11:08
* roam-apps path and policy update

* updating styling policy

* increasing time for building ci

* increasing time for ci build

* putting back time for lint
… in Parent Signup flow (#1014)

* edit text to include roar research portal

* Update src/pages/RegisterFamilyUsers.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

* add validation for activation code expiration based on time based comparison

* add validation for activation code expiration based on time based comparison

* add error message for post-submission

* remove extraneous import

* fix error validation for miniumum character password input

* fix issue where password mismatch still allows submit

* update to use dateExpired to check expiration

* increasing time for ci build

---------

Co-authored-by: Adam Richie-Halford <[email protected]>
Co-authored-by: emily-ejag <[email protected]>
* Update img-src CSP

* Fix cloud functions host CSP

* Update firebase.json

* Update firebase.json

* increasing time for ci build

* Add buckets to img-src and media-src CSP

* Remove deprecatd roam-fluency bucket

---------

Co-authored-by: Adam Richie-Halford <[email protected]>
Co-authored-by: Emily Arteaga-Garcia <[email protected]>
Co-authored-by: emily-ejag <[email protected]>
* Includes  new parameter validation method

* Update SWR version to 1.13.0

* update roar-firekit to latest version

* Update ROAV-Crowding version to 1.1.35 (#1017)

Co-authored-by: AryamanTaore <[email protected]>

* 3.4.1

* increasing time for ci build

* update roar-firebase-functions submodule

---------

Co-authored-by: ksmontville <[email protected]>
Co-authored-by: Kyle <[email protected]>
Co-authored-by: AryamanTaore <[email protected]>
Co-authored-by: emily-ejag <[email protected]>
Co-authored-by: Emily Arteaga-Garcia <[email protected]>
* Update SRE version to 1.16.0

* updating cypress tests

---------

Co-authored-by: Emily-ejag <[email protected]>
Co-authored-by: emily-ejag <[email protected]>
Co-authored-by: Emily Arteaga-Garcia <[email protected]>
* Adding ROAR - Phonics

* One package for letter and phonics

* score report allowing phonics

---------

Co-authored-by: Adam Richie-Halford <[email protected]>
* correcting CSS tag color place

* Update src/components/reports/TableScoreTag.vue

Co-authored-by: Kyle Montville <[email protected]>

* formatting and linting

* Update src/components/reports/TableScoreTag.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

* formatting and linting

---------

Co-authored-by: Kyle Montville <[email protected]>
Co-authored-by: Adam Richie-Halford <[email protected]>
* scores for alpaca

* Update src/containers/Navigation/Navigation.vue

Co-authored-by: Adam Richie-Halford <[email protected]>

---------

Co-authored-by: Adam Richie-Halford <[email protected]>
* Update roam-apps version to 1.0.11

* roam core scores

* updating roam

---------

Co-authored-by: KruttikaBhat <[email protected]>
Co-authored-by: Emily Arteaga-Garcia <[email protected]>
Co-authored-by: emily-ejag <[email protected]>
@maximilianoertel maximilianoertel requested a review from a team as a code owner February 12, 2025 11:29
@maximilianoertel maximilianoertel changed the base branch from main to feat/project-config February 12, 2025 11:29
@maximilianoertel maximilianoertel added the enhancement New feature or request label Feb 12, 2025
@maximilianoertel maximilianoertel self-assigned this Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1362 for commit 9d5fb6b by the Vitest Coverage Report Action

Copy link

cypress bot commented Feb 12, 2025

roar-dashboard-e2e    Run #10988

Run Properties:  status check failed Failed #10988  •  git commit 51166e550e: Update `feat/project-config` from `main` (#1037)
Project roar-dashboard-e2e
Branch Review ref/update-from-main
Run status status check failed Failed #10988
Run duration 20m 32s
Commit git commit 51166e550e: Update `feat/project-config` from `main` (#1037)
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 51
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/partner-admin/default-tests/scoreReports.cy.js • 1 failed test

View Output

Test Artifacts
Partner Admin: Score Reports > Renders an administration's score report Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants