Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Pluralize Orgs #1039

Merged
merged 1 commit into from
Feb 13, 2025
Merged

FIX Pluralize Orgs #1039

merged 1 commit into from
Feb 13, 2025

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Feb 13, 2025

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Emily-ejag Emily-ejag requested a review from a team as a code owner February 13, 2025 21:02
@Emily-ejag Emily-ejag self-assigned this Feb 13, 2025
@Emily-ejag Emily-ejag added the bug Something isn't working label Feb 13, 2025
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1365 for commit a588aa6 by the Vitest Coverage Report Action

Copy link

github-actions bot commented Feb 13, 2025

Visit the preview URL for this PR (updated for commit a588aa6):

https://roar-staging--pr1039-fix-pluralize-orgs-54h4okkk.web.app

(expires Thu, 20 Feb 2025 21:08:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Feb 13, 2025

roar-dashboard-e2e    Run #11006

Run Properties:  status check passed Passed #11006  •  git commit a588aa6a7f: E2E Tests for PR 1039 "FIX Pluralize Orgs" from commit "a588aa6a7f22d17d4dc6d8db...
Project roar-dashboard-e2e
Branch Review fix/pluralize-orgs
Run status status check passed Passed #11006
Run duration 05m 36s
Commit git commit a588aa6a7f: E2E Tests for PR 1039 "FIX Pluralize Orgs" from commit "a588aa6a7f22d17d4dc6d8db...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@Emily-ejag Emily-ejag merged commit c0b0499 into main Feb 13, 2025
25 checks passed
@Emily-ejag Emily-ejag deleted the fix/pluralize-orgs branch February 13, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants