Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security headers #998

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Update security headers #998

merged 8 commits into from
Jan 15, 2025

Conversation

maximilianoertel
Copy link
Collaborator

@maximilianoertel maximilianoertel commented Jan 10, 2025

Proposed changes

This PR updates the security headers configured in the firebase.json file, primarily to improve the Content Security Policy (CSP) for the ROAR Dashboard.

Initially, the updated CSP will be deployed in a report-only mode with reporting to Sentry. This will allow us to test and monitor the proposed CSP changes, and identify any potential issues or violations before promoting the changes to a strict enforcement mode.

For local development, the Vite dev server parses the staging configuration and injects the CSP with strict enforcement in order to identify issues early in the development lifecycle.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Ref https://github.com/yeatmanlab/roar-project-management/issues/438

@maximilianoertel maximilianoertel requested a review from a team as a code owner January 10, 2025 16:08
Copy link

github-actions bot commented Jan 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1200 for commit 8dc3444 by the Vitest Coverage Report Action

Copy link

cypress bot commented Jan 10, 2025

roar-dashboard-e2e    Run #10276

Run Properties:  status check passed Passed #10276  •  git commit 8dc344456c: E2E Tests for PR 998 "Update security headers" from commit "8dc344456c62807f411f...
Project roar-dashboard-e2e
Branch Review enh/438/security-headers
Run status status check passed Passed #10276
Run duration 03m 46s
Commit git commit 8dc344456c: E2E Tests for PR 998 "Update security headers" from commit "8dc344456c62807f411f...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@maximilianoertel maximilianoertel force-pushed the enh/438/security-headers branch from 214469c to 3f9e52c Compare January 10, 2025 16:27
Copy link

github-actions bot commented Jan 10, 2025

Visit the preview URL for this PR (updated for commit 8dc3444):

https://roar-staging--pr998-enh-438-security-hea-7h2prpsc.web.app

(expires Tue, 21 Jan 2025 23:51:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@maximilianoertel maximilianoertel force-pushed the enh/438/security-headers branch 2 times, most recently from b3468fb to 334d7e2 Compare January 10, 2025 21:56
@maximilianoertel maximilianoertel force-pushed the enh/438/security-headers branch from bc687bd to 42876de Compare January 13, 2025 21:42
@maximilianoertel maximilianoertel force-pushed the enh/438/security-headers branch from 42876de to 2db4015 Compare January 13, 2025 21:58
@maximilianoertel maximilianoertel self-assigned this Jan 13, 2025
@maximilianoertel maximilianoertel added the enhancement New feature or request label Jan 13, 2025
@maximilianoertel maximilianoertel force-pushed the enh/438/security-headers branch from bd4da43 to dbd8332 Compare January 13, 2025 22:44
@maximilianoertel maximilianoertel merged commit f389a29 into main Jan 15, 2025
24 checks passed
@maximilianoertel maximilianoertel deleted the enh/438/security-headers branch January 15, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants