-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security headers #998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
roar-dashboard-e2e
|
Project |
roar-dashboard-e2e
|
Branch Review |
enh/438/security-headers
|
Run status |
|
Run duration | 03m 46s |
Commit |
|
Committer | Maximilian Oertel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
14
|
View all changes introduced in this branch ↗︎ |
214469c
to
3f9e52c
Compare
Visit the preview URL for this PR (updated for commit 8dc3444): https://roar-staging--pr998-enh-438-security-hea-7h2prpsc.web.app (expires Tue, 21 Jan 2025 23:51:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
b3468fb
to
334d7e2
Compare
bc687bd
to
42876de
Compare
42876de
to
2db4015
Compare
bd4da43
to
dbd8332
Compare
Emily-ejag
approved these changes
Jan 13, 2025
richford
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the security headers configured in the
firebase.json
file, primarily to improve the Content Security Policy (CSP) for the ROAR Dashboard.Initially, the updated CSP will be deployed in a report-only mode with reporting to Sentry. This will allow us to test and monitor the proposed CSP changes, and identify any potential issues or violations before promoting the changes to a strict enforcement mode.
For local development, the Vite dev server parses the staging configuration and injects the CSP with strict enforcement in order to identify issues early in the development lifecycle.
Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Ref https://github.com/yeatmanlab/roar-project-management/issues/438