-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration puzzles for model #533
Conversation
in this pull request I also added a Besides that we need to provide |
@yegor256 please take a look |
@h1alexbel the build fails. I guess, you need to merge |
@yegor256 bracnhes merged |
@yegor256 reminder |
@yegor256 ping |
@pnatashap can you please review this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should be fixed
.github/workflows/plantuml.yml
Outdated
- name: Commit changes | ||
uses: EndBug/add-and-commit@v9 | ||
with: | ||
author_name: ${{ secrets.USERNAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it is better to get author from push event? There is pusher object with name and email.
It should be something like github.event.pusher.name
and github.event.pusher.email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnatashap fixed, take a look, please
Co-authored-by: Natalia Pozhidaeva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
+ Coverage 34.85% 34.97% +0.12%
==========================================
Files 39 47 +8
Lines 1185 1298 +113
==========================================
+ Hits 413 454 +41
- Misses 772 844 +72 ☔ View full report in Codecov by Sentry. |
@rultor merge |
@h1alexbel @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@yegor256 estimates fixed, try again, please |
@rultor merge |
Added the initial integration puzzles for puzzle prioritization module (
model
).Documented an integration with UML sequence diagram: use of
LinearModel#predict(...)
inside original 0pdd.ref: #532