Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration puzzles for model #533

Merged
merged 6 commits into from
Feb 2, 2024
Merged

integration puzzles for model #533

merged 6 commits into from
Feb 2, 2024

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Jan 4, 2024

Added the initial integration puzzles for puzzle prioritization module (model).
Documented an integration with UML sequence diagram: use ofLinearModel#predict(...) inside original 0pdd.

ref: #532

@h1alexbel
Copy link
Contributor Author

in this pull request I also added a plantuml.yml GitHub Action for diagram generation, I'm not sure do we really need it or not, but its there (I don't think we need to store just SVGs or PNGs).

Besides that we need to provide EMAIL and USERNAME of the person who will sign the commit with generated diagram.
I can put [email protected] and yegor256.

@h1alexbel
Copy link
Contributor Author

@yegor256 please take a look

@yegor256
Copy link
Owner

@h1alexbel the build fails. I guess, you need to merge master into your branch

@h1alexbel
Copy link
Contributor Author

@yegor256 bracnhes merged

@h1alexbel
Copy link
Contributor Author

@yegor256 reminder

@h1alexbel
Copy link
Contributor Author

@yegor256 ping

@yegor256
Copy link
Owner

@pnatashap can you please review this pull request?

Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be fixed

.github/workflows/plantuml.yml Outdated Show resolved Hide resolved
- name: Commit changes
uses: EndBug/add-and-commit@v9
with:
author_name: ${{ secrets.USERNAME }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it is better to get author from push event? There is pusher object with name and email.
It should be something like github.event.pusher.name and github.event.pusher.email

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnatashap fixed, take a look, please

@h1alexbel h1alexbel requested a review from pnatashap February 1, 2024 13:40
Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7459a42) 34.85% compared to head (0b3cb9e) 34.97%.
Report is 140 commits behind head on master.

❗ Current head 0b3cb9e differs from pull request most recent head d095ef4. Consider uploading reports for the commit d095ef4 to get more accurate results

Files Patch % Lines
model/linear.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   34.85%   34.97%   +0.12%     
==========================================
  Files          39       47       +8     
  Lines        1185     1298     +113     
==========================================
+ Hits          413      454      +41     
- Misses        772      844      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yegor256
Copy link
Owner

yegor256 commented Feb 2, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@h1alexbel @yegor256 Oops, I failed. You can see the full log here (spent 2min)

Reading test/fake_gitlab.rb ...
Reading test/fake_log.rb ...
Reading test/fake_repo.rb ...
Reading test/fake_storage.rb ...
Reading test/fake_tickets.rb ...
Reading test/test_0pdd.rb ...
Reading test/test__helper.rb ...
Reading test/test_cached_storage.rb ...
Reading test/test_commit_tickets.rb ...
Reading test/test_credentials.rb ...
Reading test/test_diff.rb ...
Reading test/test_diff_complicated.rb ...
Puzzle 234-12f515de 15/DEV at test/test_diff_complicated.rb
Reading test/test_exec.rb ...
Reading test/test_git_repo.rb ...
Reading test/test_github.rb ...
Reading test/test_github_invitations.rb ...
Reading test/test_github_tickets.rb ...
Reading test/test_gitlab.rb ...
Reading test/test_job.rb ...
Reading test/test_job_commiterrors.rb ...
Reading test/test_job_detached.rb ...
Reading test/test_job_emailed.rb ...
Reading test/test_log.rb ...
Reading test/test_logged_storage.rb ...
Reading test/test_logged_tickets.rb ...
Reading test/test_maybe_text.rb ...
Reading test/test_milestone_tickets.rb ...
Reading test/test_once_storage.rb ...
Reading test/test_puzzles.rb ...
Reading test/test_safe_storage.rb ...
Reading test/test_sentry_tickets.rb ...
Reading test/test_truncated.rb ...
Reading test/test_upgraded_storage.rb ...
Reading test/test_versioned_storage.rb ...
Reading test-assets/puzzles/closes-one-puzzle.xml ...
Reading test-assets/puzzles/ignores-unknown-issues.xml ...
Reading test-assets/puzzles/notify-unknown-open-issues.xml ...
Reading test-assets/puzzles/simple.xml ...
Reading test-assets/puzzles/submits-old-puzzles.xml ...
Reading test-assets/puzzles/submits-ranked-puzzles.xml ...
Reading test-assets/puzzles/submits-three-tickets.xml ...
Reading version.rb ...
Reading views/_footer.haml ...
Reading views/_header.haml ...
Reading views/error.haml ...
Reading views/error_400.haml ...
Reading views/index.haml ...
Reading views/item.haml ...
Reading views/layout.haml ...
Reading views/log.haml ...
Reading views/not_found.haml ...
ERROR: Puzzle model/linear.rb:30-32 has an estimate of 0 minutes, which is lower than 15 minutes
ERROR: Puzzle model/linear.rb:55-60 has an estimate of 0 minutes, which is lower than 15 minutes
ERROR: Puzzle objects/puzzles.rb:28-32 has an estimate of 0 minutes, which is lower than 15 minutes
ERROR: ERROR: 3 errors, see log above
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/cqfn/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/cqfn/pdd/blob/master/README.md.
Exit code is 1
container 5281e9ac57a5b8a65d24108be5dc2e0c50baf66609eb7719b80b48ae8b1d54cf is dead
Fri Feb  2 06:11:36 AM CET 2024

@h1alexbel
Copy link
Contributor Author

h1alexbel commented Feb 2, 2024

@yegor256 estimates fixed, try again, please

@yegor256
Copy link
Owner

yegor256 commented Feb 2, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9d7b1ae into yegor256:master Feb 2, 2024
4 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 2, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

@h1alexbel h1alexbel deleted the 532 branch February 2, 2024 14:42
@h1alexbel h1alexbel restored the 532 branch February 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants