Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1466 Added titled #1474

Closed
wants to merge 1 commit into from
Closed

#1466 Added titled #1474

wants to merge 1 commit into from

Conversation

kokodyn
Copy link
Contributor

@kokodyn kokodyn commented Sep 27, 2020

Converts the text into titled case.
Added Title which is required to my other PR(Added Capitalized).

Signed-off-by: kokodyn [email protected]

Converts the text into titled case.

Signed-off-by: kokodyn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1474 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1474      +/-   ##
============================================
+ Coverage     89.28%   89.33%   +0.05%     
+ Complexity     1661     1628      -33     
============================================
  Files           278      277       -1     
  Lines          3965     3901      -64     
  Branches        209      209              
============================================
- Hits           3540     3485      -55     
+ Misses          392      383       -9     
  Partials         33       33              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/text/Titled.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/map/Synced.java 28.57% <0.00%> (-8.93%) 3.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/map/MapEnvelope.java 91.66% <0.00%> (-6.12%) 15.00% <0.00%> (-15.00%)
src/main/java/org/cactoos/map/MapOf.java 100.00% <0.00%> (ø) 10.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/map/Merged.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/main/java/org/cactoos/map/Grouped.java 100.00% <0.00%> (ø) 1.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/map/Sticky.java
src/main/java/org/cactoos/map/Solid.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af979de...d76d769. Read the comment docs.

@victornoel
Copy link
Collaborator

@kokodyn I'm a bit worried about the naming because from a user point of view, if I read the term Titled, I'm expecting the string to be transformed to a title, i.e. with the first character of each word being titled case. Do you have other idea to name this?

IMHO it would have been best to first merge the other PR #1465 with a @todo and then we could have taken the time to think about this problem.... maybe we need another abstraction for characters that shouldn't be confused with Text. It's not clear.

@victornoel
Copy link
Collaborator

@kokodyn I'm going to close this as #1465 is being merged. Also don't hesitate to join Zerocracy and this project if you want to contribute here and learn to use zerocracy :) see http://www.zerocracy.com/faq.html for details!

@victornoel victornoel closed this Oct 4, 2020
@0crat
Copy link
Collaborator

0crat commented Oct 4, 2020

Job gh:yegor256/cactoos#1474 is not assigned, can't get performer

@kokodyn
Copy link
Contributor Author

kokodyn commented Oct 7, 2020

@victornoel Thanks for invitation to "join Zerocracy" I will consider it :)

@kokodyn kokodyn deleted the TITLED branch October 7, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants