-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1533) More variance on some generics #1534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1534 +/- ##
============================================
- Coverage 90.84% 90.81% -0.04%
- Complexity 1553 1554 +1
============================================
Files 284 284
Lines 3672 3668 -4
Branches 125 125
============================================
- Hits 3336 3331 -5
Misses 306 306
- Partials 30 31 +1
Continue to review full report at Codecov.
|
This pull request #1534 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel It looks good for me :)
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 8min) |
Job was finished in 1 hours, bonus for fast delivery is possible (see §36) |
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality bad |
Quality is low, no payment, see §31 |
This is related to #1533, I need it for #1335 but I'm dedicating a PR to it.