-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Fallback
instead of Func
#1615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1615 +/- ##
============================================
+ Coverage 90.07% 90.09% +0.01%
+ Complexity 1602 1601 -1
============================================
Files 298 298
Lines 3748 3745 -3
Branches 122 122
============================================
- Hits 3376 3374 -2
+ Misses 338 337 -1
Partials 34 34
Continue to review full report at Codecov.
|
@0crat status |
1 similar comment
@0crat status |
@andreoss I was surprised when I saw that UncheckedBytes, contrary to many of the other UncheckedXXX classes this fallback paramter... I'm not convinced there is a real use for this. I would instead propose to remove this parameter at all, here and in the other UncheckedXXX classes. Along with this, we can think about introducing and unifying how all the WDYT? If you like the idea and create a ticket for it, I will put it in scope |
@andreoss one of the tests if failing apparently |
@victornoel A flaky test, apparently. |
@andreoss yep… let's just ignore it ^^ |
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 11min) |
Job |
@0crat status |
No description provided.