Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThrowsOnFalse #1692

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions src/main/java/org/cactoos/scalar/ThrowsOnFalse.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2017-2022 Yegor Bugayenko
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included
* in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/

package org.cactoos.scalar;

import org.cactoos.Scalar;

/**
* Throws an exception on false expression.
*
* @since 0.56.0
*/
public final class ThrowsOnFalse implements Scalar<Boolean> {

/**
* Logical statement.
*/
private final Scalar<Boolean> scalar;

/**
* Exception to throw.
*/
private final Scalar<Exception> exception;

/**
* Ctor.
* @param sclr Scalar
* @param exc Exception
*/
public ThrowsOnFalse(
final Scalar<Boolean> sclr,
final Scalar<Exception> exc
) {
this.scalar = sclr;
this.exception = exc;
}

/**
* Ctor.
* @param sclr Scalar
* @param message Error Message
*/
public ThrowsOnFalse(
final Scalar<Boolean> sclr,
final String message
) {
this(
sclr, () -> new IllegalArgumentException(message)
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel please put the constructor in this order in the file: first secondary constructor (the one taking a String) and last primary constructor (the one taking the two scalars).

}

@Override
public Boolean value() throws Exception {
if (!this.scalar.value()) {
throw this.exception.value();
}
return true;
}
}
61 changes: 61 additions & 0 deletions src/test/java/org/cactoos/scalar/ThrowsOnFalseTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2017-2022 Yegor Bugayenko
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included
* in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/

package org.cactoos.scalar;

import org.hamcrest.core.IsEqual;
import org.junit.Test;
import org.llorllale.cactoos.matchers.Assertion;

/**
* Test suite for {@link ThrowsOnFalse}.
*
* @since 0.56.0
*/
public final class ThrowsOnFalseTest {

@Test(expected = IllegalArgumentException.class)
public void throwsOnFalse() throws Exception {
new ThrowsOnFalse(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel please use org.llorllale.cactoos.matchers.Throws with Assertion to check for exception (instead of using expected = IllegalArgumentException.class)

() -> false, "test message"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel also check for the error message itself, not only that the exception is thrown

).value();
}

@Test(expected = IllegalStateException.class)
public void throwsSuppliedExceptionOnFalse() throws Exception {
new ThrowsOnFalse(
() -> false,
() -> new IllegalStateException("illegal state")
).value();
}

@Test
public void returnsTrueOnTrue() throws Exception {
new Assertion<>(
"Must return true on true statement",
new ThrowsOnFalse(() -> true, "test").value(),
new IsEqual<>(true)
).affirm();
}
}