Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an OOP analogue for StringUtils.splitPreserveAllTokens #1742

Closed
wants to merge 3 commits into from

Conversation

tjann7
Copy link
Contributor

@tjann7 tjann7 commented Nov 1, 2024

This pull request corresponds to issue #1722

Rationale of some decisions made:

  1. Functional Interface allows use of custom String splitter function avoiding the static method calls
  2. A new class created as modifying already existing Split class would not be shorter : if we add some checking for flags would create just as many constructors as with 2 distinct classes
  3. Tests only compare lengths of obtained Collections

@tjann7 tjann7 closed this Nov 1, 2024
@tjann7 tjann7 reopened this Nov 1, 2024
@tjann7 tjann7 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant