Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ast type hints #176

Merged
merged 14 commits into from
Mar 6, 2024
Merged

Ast type hints #176

merged 14 commits into from
Mar 6, 2024

Conversation

ilnarkhasanov
Copy link
Contributor

@ilnarkhasanov ilnarkhasanov commented Feb 28, 2024

Closes #171

@yegor256
Copy link
Owner

@ilnarkhasanov is it possible to configure pylint or maybe some other code analysis tool such that it catches Python code without type hints? If we add such a tool to the build, it will help us avoid similar problems in the future.

@yegor256
Copy link
Owner

@ilnarkhasanov maybe you can just add mypy to our existing lint.sh script, where we call pylint. There is no need to create a separate Github Actions job, I believe.

@ilnarkhasanov
Copy link
Contributor Author

@yegor256 I have added mypy to the lint.sh. Could you check, please?

@yegor256
Copy link
Owner

yegor256 commented Mar 6, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 6, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b785bef into yegor256:master Mar 6, 2024
4 checks passed
@rultor
Copy link
Collaborator

rultor commented Mar 6, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 15min)

@yegor256
Copy link
Owner

yegor256 commented Mar 6, 2024

@ilnarkhasanov thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hints for ast.py
3 participants