-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5 New metric: age of class in hours #380
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
285356f
Create aocih.sh
lueFlake 9ec96fc
added tests for aocih
lueFlake b488e8b
Update aocih.sh
lueFlake c089293
Update aocih.sh
lueFlake 5a9d337
fixed aocih.sh
lueFlake d4b614b
Update aocih.sh
lueFlake c29bd5a
Update aocih.sh
lueFlake 3be7bb7
refactor of condition
lueFlake 067001e
Update aocih.sh
lueFlake e22a5e6
chmod +x executed
c799d9c
Merge branch 'aocih-metric' of https://github.com/lueFlake/cam into a…
lueFlake 01f8be5
Update test-aocih.sh
lueFlake 6633d7a
Update test-aocih.sh
lueFlake 7aded1b
make test even more certain
lueFlake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/usr/bin/env bash | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
|
||
set -e | ||
set -o pipefail | ||
|
||
java_file=$1 | ||
output=$2 | ||
|
||
creation_timestamp=$(git log --diff-filter=A --format=%at -- "$java_file" | tail -1) | ||
if [[ -z "$creation_timestamp" ]]; then | ||
age_in_hours=0 | ||
else | ||
current_timestamp=$(date +%s) | ||
age_in_seconds=$((current_timestamp - creation_timestamp)) | ||
age_in_hours=$((age_in_seconds / 3600)) | ||
fi | ||
|
||
echo "AoCiH $age_in_hours Age of the class in hours" > "$output" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
#!/usr/bin/env bash | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
set -e | ||
set -o pipefail | ||
|
||
temp=$1 | ||
stdout=$2 | ||
|
||
{ | ||
tmp=$(mktemp -d /tmp/XXXX) | ||
"${LOCAL}/metrics/age_of_class.sh" "${tmp}/Test.java" "${temp}/stdout" | ||
grep -q "AoCiH 0 " "${temp}/stdout" | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 Didn't fail in non-git directory" | ||
|
||
{ | ||
mkdir -p "${temp}/foo" | ||
cd "${temp}/foo" | ||
git init --quiet . | ||
git config user.email '[email protected]' | ||
git config user.name 'Foo' | ||
java="Test.java" | ||
echo "class Foo {}" > "${java}" | ||
git add "${java}" | ||
git config commit.gpgsign false | ||
git commit --quiet -am "Initial commit" | ||
"${LOCAL}/metrics/age_of_class.sh" "${java}" stdout | ||
grep -qP "AoCiH [^0]" stdout | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 Correctly calculated AoCiH in the repository" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lueFlake "age of class in hours" is the number of hours since the date of birth of the repository. It has nothing to do with the current time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 you mean difference between date of birth and date of class creation? i think i can redo it then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lueFlake yes, like this:
Here, A is the age of file, C is the time when the file was first time added to the repo, and D is the time when the first file was added to the repo.