Fix of sporadic make error 141. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 could you check |
yegor256
reviewed
Jan 19, 2025
|
@yegor256 I can't reproduce the error on my machine, failling test passes fine. |
yegor256
reviewed
Jan 22, 2025
steps/env.sh
Outdated
| @@ -42,6 +42,7 @@ fi | |||
| ruby -v | |||
| rubocop -v | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@yegor256 I just wanted to rerun github actions to discover wheter the problem is sporadic or not
yegor256
reviewed
Jan 22, 2025
metrics/aocih.sh
Outdated
| if [[ -n "$file_first_commit" ]]; then | ||
| repo_first_commit=$(git log --reverse --format=%at | head -n 1 || true) | ||
| file_first_commit=$(git log --diff-filter=A --format=%at -- "$java_file" | tail -n 1 || true) | ||
|
|
There was a problem hiding this comment.
@dzhovi try to refrain from empty lines inside code blocks: https://www.yegor256.com/2014/11/03/empty-line-code-smell.html
The length of the URL in 'howpublished' is too big (67 > 64), use URL shoftener: 'https://github.blog/2023-01-25-100-million-developers-and-counting/', in the 'dohmke2023' entry
|
@yegor256 i think i fixed tests, |
|
@dzhovi thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#405