Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

fix(gulpfile): gulp bower not wiring deps correctly #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfonso-presa
Copy link

This solved the problem reported in #1199 for me.

Closes #1199

@agalitsyn
Copy link

Hi, when it will be merged? Bug #1199 still reproducable

@alfonso-presa
Copy link
Author

No idea....
Owners/Colabs, any feedback?

@alfonso-presa
Copy link
Author

I've had to rebase this due to conflicts... Anything I can do to help speed this PR's merge?

Thanks!

@mnloop
Copy link

mnloop commented Apr 22, 2016

It fixed, thanks! I've to download this patch and apply it manually.

For created project:

cd /path/to/created/project/
curl -LO https://github.com/yeoman/generator-angular/pull/1247.patch
patch -b gulpfile.js 1247.patch

For generator-angular:

cd /usr/local/lib/node_modules/generator-angular
curl -LO https://github.com/yeoman/generator-angular/pull/1247.patch
patch -b -p1 < 1247.patch

@mnloop
Copy link

mnloop commented Apr 22, 2016

The test/karma.conf.js file also need to be updated.

@ghost
Copy link

ghost commented Aug 20, 2016

One thing that would be nice is if the bower task could be added into task chain of tasks such as default or serve. Currently, the bower task appears to only run if bower.json is changed.

@bretmattingly
Copy link

+1 to @LonnyGomes' comment.

@MatissJanis
Copy link

Why has this not been merged yet? The issue still persists and this fixes it.

@gscottqueen
Copy link

yup, issue still there and this worked for me.

@jfrumar
Copy link

jfrumar commented Feb 4, 2017

Merge please

@alfonso-presa
Copy link
Author

Is this ever going to be merged? Should I drop the PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants