Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PartialEq, Eq and Hash for Uri. #9

Closed
wants to merge 2 commits into from

Conversation

gibbz00
Copy link

@gibbz00 gibbz00 commented Oct 6, 2023

src/lib.rs Show resolved Hide resolved
@the-kenny
Copy link

Hello,

We just started using fluent_uri in a (for-now) internal project. Is there something blocking the merge of this change? If so, could you kindly explain what needs to be done? We could use the ability for comparison.

Cheers
Moritz

@gibbz00
Copy link
Author

gibbz00 commented Dec 16, 2023

I don't think anything is "blocking" the merge in the traditional sense, it's more that we haven't heard anything from the repo owner.

There's nothing stopping you from using this feature right now though, just append this to your Cargo.toml 😊

[patch.crates-io]
# https://github.com/yescallop/fluent-uri-rs/pull/9
fluent-uri = { git = "https://github.com/gibbz00/fluent-uri-rs", branch = "main" }

@yescallop
Copy link
Owner

Thanks for your contribution! I have implemented the changes on main, but I still need some time to clean up before a 0.2.0 release. Feel free to ping me if you'd like to have them published in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants