Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yesod-core: Dispatch builds with 'wai-extra >= 3.0.7' again #1861

Merged
merged 3 commits into from
Mar 3, 2025
Merged

yesod-core: Dispatch builds with 'wai-extra >= 3.0.7' again #1861

merged 3 commits into from
Mar 3, 2025

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Mar 2, 2025 •
edited
Loading

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Sorry for the breakage, this should make it build with any wai-extra from 3.0.7 onwards again.

@Vlix
Copy link
Contributor Author

Vlix commented Mar 2, 2025

Fixes #1854 and makes #1856 unnecessary

jezen
jezen approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@jezen jezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks!

@jezen jezen merged commit ef5cc53 into yesodweb:master Mar 3, 2025
13 checks passed
@Vlix Vlix mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezen jezen jezen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @jezen