Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

진하늘 과제1 #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

진하늘 과제1 #18

wants to merge 8 commits into from

Conversation

mewluee
Copy link
Contributor

@mewluee mewluee commented Jun 14, 2023

@mewluee mewluee self-assigned this Jun 14, 2023
@kimyoungi99 kimyoungi99 self-requested a review June 14, 2023 07:37
kimyoungi99
kimyoungi99 reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@kimyoungi99 kimyoungi99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로, 기능에 대한 테스트코드 작성해주세요.
ykapi를 mock으로 주입하여 테스트하는 방식이면 좋을 것 같습니당.

hn/src/main/java/com/example/hn/homework1/response/ABResponse.java Outdated Show resolved Hide resolved
hn/src/main/java/com/example/hn/homework1/service/HomeworkService.java Outdated Show resolved Hide resolved
hn/src/main/java/com/example/hn/homework1/service/YkService.java Outdated Show resolved Hide resolved
hn/src/main/java/com/example/hn/homework1/service/YkService.java Outdated Show resolved Hide resolved
hn/src/main/java/com/example/hn/homework1/service/HomeworkService.java Outdated Show resolved Hide resolved
hn/src/main/java/com/example/hn/homework1/service/HomeworkService.java Outdated Show resolved Hide resolved
@kimyoungi99 kimyoungi99 mentioned this pull request Jun 15, 2023
Open
@kimyoungi99
Copy link
Contributor

spring boot 테스트를 작성하셨군요!!

mockito를 사용한 클래스 레벨 테스트도 작성해보는게 좋아 보입니다!!
참고

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimyoungi99 kimyoungi99 kimyoungi99 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mewluee mewluee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mewluee @kimyoungi99