안윤아 과제 제출 #23
Open
안윤아 과제 제출 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimyoungi99
reviewed
Jun 18, 2023
| private final YaClient yaClient; | ||
|
|
||
| public String ykCallService(int x){ | ||
|
|
There was a problem hiding this comment.
nit :
개행 정리해주세요. 현재 함수전체에서 2개정도면 충분할거 같아요!
| Integer numA = yaClient.calculateQuadraticEquation(1); | ||
| Integer numB = yaClient.calculateQuadraticEquation(2); | ||
|
|
||
| Integer resultA = (numB - (numA*2))/2; |
There was a problem hiding this comment.
nit :
Integer resultA = (numB - (numA * 2)) / 2;
|
|
||
| Integer resultB = numA - resultA; | ||
|
|
||
| String result = "a의 값은: "+resultA +" b의 값은: "+resultB; |
There was a problem hiding this comment.
nit :
String result = "a의 값은: " + resultA + " b의 값은: " + resultB;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1차 과제 제출합니다