remove the Clone of WorkerProviderState

yewstack · Oct 2, 2023 · 96649bc · 96649bc
1 parent 5f546ea
commit 96649bc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 18 deletions.
diff --git a/packages/yew-agent/src/scope_ext.rs b/packages/yew-agent/src/scope_ext.rs
@@ -99,7 +99,7 @@ where
         W: Worker + 'static,
     {
         let inner = self
-            .context::<WorkerProviderState<W>>((|_| {}).into())
+            .context::<Rc<WorkerProviderState<W>>>((|_| {}).into())
             .expect_throw("failed to bridge to agent.")
             .0
             .create_bridge(callback);

diff --git a/packages/yew-agent/src/worker/hooks.rs b/packages/yew-agent/src/worker/hooks.rs
@@ -84,7 +84,7 @@ where
 {
     let ctr = use_reducer(BridgeIdState::default);
 
-    let worker_state = use_context::<WorkerProviderState<T>>()
+    let worker_state = use_context::<Rc<WorkerProviderState<T>>>()
         .expect_throw("cannot find a provider for current agent.");
 
     let on_output = Rc::new(on_output);

diff --git a/packages/yew-agent/src/worker/provider.rs b/packages/yew-agent/src/worker/provider.rs
@@ -88,20 +88,6 @@ where
     }
 }
 
-impl<W> Clone for WorkerProviderState<W>
-where
-    W: Worker,
-{
-    fn clone(&self) -> Self {
-        Self {
-            id: self.id,
-            spawn_bridge_fn: self.spawn_bridge_fn.clone(),
-            reach: self.reach,
-            held_bridge: self.held_bridge.clone(),
-        }
-    }
-}
-
 impl<W> PartialEq for WorkerProviderState<W>
 where
     W: Worker,
@@ -152,8 +138,8 @@ where
     };
 
     html! {
-        <ContextProvider<WorkerProviderState<W>> context={(*state).clone()}>
+        <ContextProvider<Rc<WorkerProviderState<W>>> context={state.clone()}>
             {children}
-        </ContextProvider<WorkerProviderState<W>>>
+        </ContextProvider<Rc<WorkerProviderState<W>>>>
     }
 }