-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the docs of set_event_bubbling
#3391
Conversation
The removed paragraph describes a caveat of the framework which is no longer true
Visit the preview URL for this PR (updated for commit 9a8bed0): https://yew-rs-api--pr3391-patch-1-1nqko81d.web.app (expires Fri, 08 Sep 2023 16:52:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this.
This behaviour should now work correctly for events registered with on*
handlers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks safe enough to merge 🤷♀️ @hamza1311 a second approval for this one?
Description
Removed a paragraph from the docs of
set_event_bubbling
which describes a caveat of the framework which is no longer trueChecklist