-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of ChildrenRenderer from nested_list #3436
Conversation
Size Comparison
|
But people do need an example for the |
vec![ | ||
html_nested! { | ||
<ListHeader text="Calling all Rusties!" {on_hover} {list_link} key="header" /> | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move these vec!
s out into variables but it's fine if you want to merge it as-is. It's just a stylistic thing to keep Rust code out of html!
. 3 levels of nested macros doesn't look that either
Examples should also be present to promote optimal pattern. All manipulation of an layout should be fully-keyed. The underlying reason is not because of performance. I would suggest to read the entire conversation in #3262 if you wish to learn more about the rationale of this change. Once layout manipulation is out of the way (what this pull request is for), then we are able to impose a VList at the outer most of an Once we made |
Description
See: #3262
This pull request removes use of
ChildrenRenderer
from examples.This further discourages manipulating Children / ChildrenRenderer which would cause keying issues.
Checklist